Issue 286920043: Adjust fuzz error dump directory

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 286920043: Adjust fuzz error dump directory

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 3 months ago by zhaoqin

Modified:
8 years, 3 months ago

Reviewers:
bruening

CC:
drmemory-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- Adjust fuzz error dump directory - update dump_fuzz_error_input() to dump error input to corpus directory if exist - add logging in load_fuzz_input ---------------

Patch Set 1 #

Total comments: 2

Patch Set 2 : final #

Patch Set 3 : final #

Patch Set 4 : Committed #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	drmemory/fuzzer.c	View	1 2	4 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bruening

LGTM w/ comments https://codereview.appspot.com/286920043/diff/1/drmemory/fuzzer.c File drmemory/fuzzer.c (right): https://codereview.appspot.com/286920043/diff/1/drmemory/fuzzer.c#newcode746 drmemory/fuzzer.c:746: char *dump_dir; const? https://codereview.appspot.com/286920043/diff/1/drmemory/fuzzer.c#newcode750 drmemory/fuzzer.c:750: /* ...

8 years, 3 months ago (2016-01-27 21:33:04 UTC) #2

zhaoqin

Commit log for latest patchset: --------------- Adjust fuzz error dump directory - update dump_fuzz_error_input() to ...

8 years, 3 months ago (2016-01-27 21:36:51 UTC) #3

zhaoqin

Commit log for latest patchset: --------------- Adjust fuzz error dump directory - update dump_fuzz_error_input() to ...

8 years, 3 months ago (2016-01-27 21:49:53 UTC) #4

zhaoqin

8 years, 3 months ago (2016-01-27 22:11:44 UTC) #5

Committed as
https://github.com/DynamoRIO/drmemory/commit/5435b0650fff6982fdd2ec6e014e7cdf...

Final commit log: 
---------------
Adjust fuzz error dump directory

- update dump_fuzz_error_input() to dump error input to corpus directory if
exist
- add logging in load_fuzz_input

Review-URL: https://codereview.appspot.com/286920043
---------------

Expand All Messages | Collapse All Messages