Issue 286430043: ticket:12012: Replace irregular sizeof expressions with UPRV_LENGTHOF().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 286430043: ticket:12012: Replace irregular sizeof expressions with UPRV_LENGTHOF(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 9 months ago by roubert (google)

Modified:
8 years, 9 months ago

Reviewers:
markus.icu

Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu/trunk

Visibility:
Public.

More Reviews

Description

ticket:12012: Replace irregular sizeof expressions with UPRV_LENGTHOF(). R=markus.icu@gmail.com Committed: http://bugs.icu-project.org/trac/changeset/38378

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+158 lines, -157 lines)			Patch
M	source/common/locmap.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/i18n/hebrwcal.cpp	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	source/test/cintltst/nccbtst.c	View	58 chunks	+146 lines, -146 lines	0 comments	Download
M	source/test/intltest/numfmtst.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	source/test/intltest/regcoll.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	source/test/intltest/transrt.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	source/test/intltest/tzrulets.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

roubert (google)

This will need careful review. I've tested with both Clang and GCC in both 32-bit ...

8 years, 9 months ago (2016-02-25 16:14:21 UTC) #1

roubert (google)

8 years, 9 months ago (2016-02-26 11:22:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 38378 (presubmit successful).

Expand All Messages | Collapse All Messages