source/test/intltest/regcoll.cpp - Issue 286430043: ticket:12012: Replace irregular sizeof expressions with UPRV_LENGTHOF().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: source/test/intltest/regcoll.cpp

Issue 286430043: ticket:12012: Replace irregular sizeof expressions with UPRV_LENGTHOF(). (Closed) Base URL: svn+ssh://source.icu-project.org/repos/icu/icu/trunk

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: source/test/intltest/regcoll.cpp

diff --git a/source/test/intltest/regcoll.cpp b/source/test/intltest/regcoll.cpp

index 7a322447aabec887a462047e89e7324e89caf0dd..dc1026deaf67489b46107e38c0e6f4bc73a2e0bb 100644

--- a/source/test/intltest/regcoll.cpp

+++ b/source/test/intltest/regcoll.cpp

@@ -1225,7 +1225,7 @@ void CollationRegressionTest::TestT7189() {

return;

}

- for (i = 0; i < sizeof(text1) / (CollationRegressionTest::MAX_TOKEN_LEN * sizeof(UChar)); i++) {

+ for (i = 0; i < UPRV_LENGTHOF(text1); i++) {

uint8_t key1[100], key2[100];

int32_t len1, len2;

« no previous file with comments | « source/test/intltest/numfmtst.cpp ('k') | source/test/intltest/transrt.cpp » ('j') | no next file with comments »