code review 28630043: gosshnew/ssh: drop redundant window update in test.

gosshnew/ssh: drop redundant window update in test.

[hanwen-google, 2013-11-19 10:45:02]

Hello agl1, dave@cheney.net, jpsugar@google.com (cc: agl@golang.org,
dave@cheney.net, golang-dev@googlegroups.com, hanwen@google.com,
jpsugar@google.com),

I'd like you to review this change to
https://hanwen%40google.com@code.google.com/p/gosshnew/

[dave_cheney.net, 2013-11-19 11:14:41]

I can't remember why I added that line, but there was probably a reason. It may
not be important now as the semantics of the channel api have changed, but I'd
like some time to review the commit log to remind myself. 

> On 19 Nov 2013 lp, at 21:45, hanwen@google.com wrote:
> 
> Reviewers: agl1, dfc, jpsugar,
> 
> Message:
> Hello agl1, dave@cheney.net, jpsugar@google.com (cc: agl@golang.org,
> dave@cheney.net, golang-dev@googlegroups.com, hanwen@google.com,
> jpsugar@google.com),
> 
> I'd like you to review this change to
> https://hanwen%40google.com@code.google.com/p/gosshnew/
> 
> 
> Description:
> gosshnew/ssh: drop redundant window update in test.
> 
> Please review this at https://codereview.appspot.com/28630043/
> 
> Affected files (+0, -4 lines):
>  M ssh/session_test.go
> 
> 
> Index: ssh/session_test.go
> ===================================================================
> --- a/ssh/session_test.go
> +++ b/ssh/session_test.go
> @@ -533,10 +533,6 @@
> 
> func discardHandler(ch *channel, t *testing.T) {
>    defer ch.Close()
> -    // grow the window to avoid being fooled by
> -    // the initial 1 << 14 window.
> -    ch.adjustWindow(1024 * 1024)
> -
>    io.Copy(ioutil.Discard, ch)
> }
> 
> 
> 

[hanwen-google, 2013-11-19 11:32:22]

On Tue, Nov 19, 2013 at 12:14 PM, Dave Cheney <dave@cheney.net> wrote:
> I can't remember why I added that line, but there was probably a reason. It
may not be important now as the semantics of the channel api have changed, but
I'd like some time to review the commit log to remind myself.

https://codereview.appspot.com/6448128/

I think it's obsolete now that we start with a 2M window.




-- 
Han-Wen Nienhuys
Google Munich
hanwen@google.com

[dave_cheney.net, 2013-11-19 11:41:32]

Fair point. LGTM. 

> On 19 Nov 2013, at 22:32, Han-Wen Nienhuys <hanwen@google.com> wrote:
> 
>> On Tue, Nov 19, 2013 at 12:14 PM, Dave Cheney <dave@cheney.net> wrote:
>> I can't remember why I added that line, but there was probably a reason. It
may not be important now as the semantics of the channel api have changed, but
I'd like some time to review the commit log to remind myself.
> 
> https://codereview.appspot.com/6448128/
> 
> I think it's obsolete now that we start with a 2M window.
> 
> 
> 
> 
> -- 
> Han-Wen Nienhuys
> Google Munich
> hanwen@google.com

[hanwen-google, 2013-11-19 11:43:59]

*** Submitted as https://code.google.com/p/gosshnew/source/detail?r=925b07ad2f79
***

gosshnew/ssh: drop redundant window update in test.

R=agl, dave, jpsugar
CC=agl, dave, golang-dev, hanwen, jpsugar
https://codereview.appspot.com/28630043