Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 285990043: Integrate Dart Formatter running it using NodeJs (preliminary)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by jacobr
Modified:
8 years, 3 months ago
Reviewers:
martinprobst
Base URL:
git@github.com:angular/ts2dart.git@master
Visibility:
Public.

Description

Integrate Dart Formatter running it using NodeJs (preliminary) BUG=

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : all tests fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+719 lines, -331 lines) Patch
M lib/expression.ts View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A lib/formatter.ts View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
M lib/main.ts View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M test/call_test.ts View 1 2 1 chunk +38 lines, -20 lines 0 comments Download
M test/declaration_test.ts View 1 2 4 chunks +121 lines, -45 lines 0 comments Download
M test/decorator_test.ts View 1 2 2 chunks +52 lines, -16 lines 0 comments Download
M test/expression_test.ts View 1 2 1 chunk +50 lines, -47 lines 0 comments Download
M test/facade_converter_test.ts View 1 2 5 chunks +182 lines, -78 lines 0 comments Download
M test/function_test.ts View 1 2 2 chunks +31 lines, -13 lines 0 comments Download
M test/literal_test.ts View 1 2 1 chunk +33 lines, -33 lines 0 comments Download
M test/main_test.ts View 1 2 2 chunks +29 lines, -28 lines 0 comments Download
M test/module_test.ts View 1 2 3 chunks +17 lines, -13 lines 0 comments Download
M test/statement_test.ts View 1 2 1 chunk +91 lines, -23 lines 0 comments Download
M test/test_support.ts View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M test/type_test.ts View 1 2 1 chunk +17 lines, -14 lines 0 comments Download

Messages

Total messages: 3
jacobr
Sent out for quick review to make sure this is reasonable before I convert more ...
8 years, 3 months ago (2016-01-26 17:18:10 UTC) #1
jacobr
https://codereview.appspot.com/285990043/diff/10001/lib/main.ts File lib/main.ts (right): https://codereview.appspot.com/285990043/diff/10001/lib/main.ts#newcode333 lib/main.ts:333: // return this.result + this.generateSourceMapComment(); Let me know if ...
8 years, 3 months ago (2016-01-26 17:19:41 UTC) #2
martinprobst
8 years, 3 months ago (2016-01-26 18:34:14 UTC) #3
https://codereview.appspot.com/285990043/diff/10001/lib/formatter.ts
File lib/formatter.ts (right):

https://codereview.appspot.com/285990043/diff/10001/lib/formatter.ts#newcode25
lib/formatter.ts:25: var code = fs.readFileSync("./lib/dart_formatter.js",
'utf-8');
> Got any tips on how I can link lib/dart_formatter.js so that it is bundled in
> the output?

Do you have an npm package for the dart formatter published? If so, you'd just
"require('dart_formatter');" (or whatever your package is called). Then you'd
just have it in "package.json" as a dependency and be good.

https://codereview.appspot.com/285990043/diff/10001/lib/main.ts
File lib/main.ts (right):

https://codereview.appspot.com/285990043/diff/10001/lib/main.ts#newcode333
lib/main.ts:333: // return this.result + this.generateSourceMapComment();
That's ok, just drop the source map part here (ok to keep in the code around, it
might be handy later on).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b