ticket:12012: Replace all sizeof p / sizeof *p with UPRV_LENGTHOF().

ticket:12012: Replace all sizeof p / sizeof *p with UPRV_LENGTHOF().

R=markus.icu@gmail.com

Committed: http://bugs.icu-project.org/trac/changeset/38337

[roubert (google), 2016-02-17 18:39:31]

These are the places where UPRV_LENGTHOF() can be replaced without manual
inspection. What'll be left to do for the ticket after this change will be to
update code of the kind sizeof p / sizeof T, which will need manual inspection
(but hopefully is much rarer in the codebase).

[markus.icu, 2016-02-18 09:41:40]

Mostly looks good.

Please check for compiler warnings from your changes, possibly truncations and
signed/unsigned mismatches.

In printf arguments, I believe you need to retain the (long) casts for %ld and
(int) casts for %d arguments, to avoid warnings on some platforms.

https://codereview.appspot.com/285520043/diff/20001/source/extra/uconv/uconv.cpp
File source/extra/uconv/uconv.cpp (right):

https://codereview.appspot.com/285520043/diff/20001/source/extra/uconv/uconv....
source/extra/uconv/uconv.cpp:947: errorLength = UPRV_LENGTHOF(errorUChars);
Do you not need to cast to (int8_t)?
Please recompile all and look for warnings.

https://codereview.appspot.com/285520043/diff/20001/source/test/cintltst/cust...
File source/test/cintltst/custrtrn.c (right):

https://codereview.appspot.com/285520043/diff/20001/source/test/cintltst/cust...
source/test/cintltst/custrtrn.c:154: (long)u32DestLen, UPRV_LENGTHOF(src32),
u_errorName(err));
On some platforms, you will get warnings because %ld wants long and
int32_t!=long. That's why we have these casts to (long).

https://codereview.appspot.com/285520043/diff/20001/source/test/intltest/tzru...
File source/test/intltest/tzrulets.cpp (right):

https://codereview.appspot.com/285520043/diff/20001/source/test/intltest/tzru...
source/test/intltest/tzrulets.cpp:3: * Copyright (C) 2007-2016, International
Business Machines Corporation and    *
Please remove the trailing spaces and * on this line and next.

[roubert (google), 2016-02-18 20:52:47]

On 2016/02/18 09:41:40, markus.icu wrote:
> Please recompile all and look for warnings.

Done. With GCC and Clang, in 32-bit and 64-bit mode, this change does not add
(or remove) any -Wall warnings when running "make check".

[roubert (google), 2016-02-18 20:53:23]

https://codereview.appspot.com/285520043/diff/20001/source/extra/uconv/uconv.cpp
File source/extra/uconv/uconv.cpp (right):

https://codereview.appspot.com/285520043/diff/20001/source/extra/uconv/uconv....
source/extra/uconv/uconv.cpp:947: errorLength = UPRV_LENGTHOF(errorUChars);
On 2016/02/18 09:41:40, markus.icu wrote:
> Do you not need to cast to (int8_t)?

This cast should be a no-op, as it is to the type of the variable to which the
value is assigned.

https://codereview.appspot.com/285520043/diff/20001/source/test/cintltst/cust...
File source/test/cintltst/custrtrn.c (right):

https://codereview.appspot.com/285520043/diff/20001/source/test/cintltst/cust...
source/test/cintltst/custrtrn.c:154: (long)u32DestLen, UPRV_LENGTHOF(src32),
u_errorName(err));
On 2016/02/18 09:41:40, markus.icu wrote:
> On some platforms, you will get warnings because %ld wants long and
> int32_t!=long. That's why we have these casts to (long).

Done.

https://codereview.appspot.com/285520043/diff/20001/source/test/intltest/tzru...
File source/test/intltest/tzrulets.cpp (right):

https://codereview.appspot.com/285520043/diff/20001/source/test/intltest/tzru...
source/test/intltest/tzrulets.cpp:3: * Copyright (C) 2007-2016, International
Business Machines Corporation and    *
On 2016/02/18 09:41:40, markus.icu wrote:
> Please remove the trailing spaces and * on this line and next.

Done.

[roubert (google), 2016-02-22 23:06:27]

Do you have any further comments?

[markus.icu, 2016-02-23 00:37:23]

Mostly LGTM.
Please fix the minor items below and then submit to the trunk.

https://codereview.appspot.com/285520043/diff/40001/source/i18n/decfmtst.cpp
File source/i18n/decfmtst.cpp (right):

https://codereview.appspot.com/285520043/diff/40001/source/i18n/decfmtst.cpp#...
source/i18n/decfmtst.cpp:3: * Copyright (C) 2009-2016, International Business
Machines Corporation and    *
Please remove the trailing spaces and asterisk, this line & next.

https://codereview.appspot.com/285520043/diff/40001/source/test/cintltst/utra...
File source/test/cintltst/utransts.c (right):

https://codereview.appspot.com/285520043/diff/40001/source/test/cintltst/utra...
source/test/cintltst/utransts.c:3: *   Copyright (C) 1997-2009,2014,2016
International Business Machines
1997-2016

https://codereview.appspot.com/285520043/diff/40001/source/test/intltest/itrb...
File source/test/intltest/itrbnf.cpp (right):

https://codereview.appspot.com/285520043/diff/40001/source/test/intltest/itrb...
source/test/intltest/itrbnf.cpp:3: * Copyright (C) 1996-2016, International
Business Machines Corporation and    *
Please remove the trailing spaces+asterisk, this line & next.

[roubert (google), 2016-02-23 10:29:05]

https://codereview.appspot.com/285520043/diff/40001/source/i18n/decfmtst.cpp
File source/i18n/decfmtst.cpp (right):

https://codereview.appspot.com/285520043/diff/40001/source/i18n/decfmtst.cpp#...
source/i18n/decfmtst.cpp:3: * Copyright (C) 2009-2016, International Business
Machines Corporation and    *
On 2016/02/23 00:37:23, markus.icu wrote:
> Please remove the trailing spaces and asterisk, this line & next.

Done.

https://codereview.appspot.com/285520043/diff/40001/source/test/cintltst/utra...
File source/test/cintltst/utransts.c (right):

https://codereview.appspot.com/285520043/diff/40001/source/test/cintltst/utra...
source/test/cintltst/utransts.c:3: *   Copyright (C) 1997-2009,2014,2016
International Business Machines
On 2016/02/23 00:37:23, markus.icu wrote:
> 1997-2016

Done.

https://codereview.appspot.com/285520043/diff/40001/source/test/intltest/itrb...
File source/test/intltest/itrbnf.cpp (right):

https://codereview.appspot.com/285520043/diff/40001/source/test/intltest/itrb...
source/test/intltest/itrbnf.cpp:3: * Copyright (C) 1996-2016, International
Business Machines Corporation and    *
On 2016/02/23 00:37:23, markus.icu wrote:
> Please remove the trailing spaces+asterisk, this line & next.

Done.

[roubert (google), 2016-02-23 10:40:18]

Committed patchset #4 (id:60001) manually as 38337 (presubmit successful).