source/common/uhash.c - Issue 285520043: ticket:12012: Replace all sizeof p / sizeof *p with UPRV_LENGTHOF().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: source/common/uhash.c

Issue 285520043: ticket:12012: Replace all sizeof p / sizeof *p with UPRV_LENGTHOF(). (Closed) Base URL: svn+ssh://source.icu-project.org/repos/icu/icu/trunk

Patch Set: Code review. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: source/common/uhash.c

diff --git a/source/common/uhash.c b/source/common/uhash.c

index 400157dc92b1c4306519a68ed526ca8f72b10701..3aa74fd3fe547106496dec9a6560ae555244358e 100644

--- a/source/common/uhash.c

+++ b/source/common/uhash.c

@@ -1,6 +1,6 @@

******************************************************************************

* Date Name Description

@@ -83,7 +83,7 @@ static const int32_t PRIMES[] = {

1073741789, 2147483647 /*, 4294967291 */

};

-#define PRIMES_LENGTH (sizeof(PRIMES) / sizeof(PRIMES[0]))

+#define PRIMES_LENGTH UPRV_LENGTHOF(PRIMES)

#define DEFAULT_PRIME_INDEX 3

/* These ratios are tuned to the PRIMES array such that a resize

« no previous file with comments | « source/common/ucurr.cpp ('k') | source/common/uloc.cpp » ('j') | no next file with comments »