Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(552)

Issue 285450043: Bug 917571 - Fix missing stdint.h for Windows XP builders (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by ttaubert
Modified:
5 years, 2 months ago
Reviewers:
mt, ekr, wtc, wtc1, ekr-rietveld
Visibility:
Public.

Description

Bug 917571 - Fix missing stdint.h for Windows XP builders

Patch Set 1 #

Total comments: 4

Patch Set 2 : Bug 917571 - Fix missing stdint.h for Windows XP builders #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M lib/freebl/chacha20.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M lib/freebl/poly1305.c View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 3
wtc1
Patch set 1 LGTM. https://codereview.appspot.com/285450043/diff/1/lib/freebl/chacha20.h File lib/freebl/chacha20.h (right): https://codereview.appspot.com/285450043/diff/1/lib/freebl/chacha20.h#newcode12 lib/freebl/chacha20.h:12: #include <prtypes.h> Please use "prtypes.h" ...
5 years, 2 months ago (2016-02-10 21:09:02 UTC) #1
ttaubert
https://codereview.appspot.com/285450043/diff/1/lib/freebl/chacha20.h File lib/freebl/chacha20.h (right): https://codereview.appspot.com/285450043/diff/1/lib/freebl/chacha20.h#newcode12 lib/freebl/chacha20.h:12: #include <prtypes.h> On 2016/02/10 21:09:02, wtc1 wrote: > > ...
5 years, 2 months ago (2016-02-11 07:38:38 UTC) #2
wtc1
5 years, 2 months ago (2016-02-11 23:02:45 UTC) #3
Message was sent while issue was closed.
Patch set 2 LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b