Issue 285450043: Bug 917571 - Fix missing stdint.h for Windows XP builders

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 285450043: Bug 917571 - Fix missing stdint.h for Windows XP builders (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by ttaubert

Modified:
9 years, 10 months ago

Reviewers:
mt, ekr, wtc, wtc1, ekr-rietveld

Visibility:
Public.

More Reviews

Description

Bug 917571 - Fix missing stdint.h for Windows XP builders

Patch Set 2 : Bug 917571 - Fix missing stdint.h for Windows XP builders #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	lib/freebl/chacha20.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	lib/freebl/poly1305.c	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

wtc1

Patch set 1 LGTM. https://codereview.appspot.com/285450043/diff/1/lib/freebl/chacha20.h File lib/freebl/chacha20.h (right): https://codereview.appspot.com/285450043/diff/1/lib/freebl/chacha20.h#newcode12 lib/freebl/chacha20.h:12: #include <prtypes.h> Please use "prtypes.h" ...

9 years, 10 months ago (2016-02-10 21:09:02 UTC) #1

ttaubert

https://codereview.appspot.com/285450043/diff/1/lib/freebl/chacha20.h File lib/freebl/chacha20.h (right): https://codereview.appspot.com/285450043/diff/1/lib/freebl/chacha20.h#newcode12 lib/freebl/chacha20.h:12: #include <prtypes.h> On 2016/02/10 21:09:02, wtc1 wrote: > > ...

9 years, 10 months ago (2016-02-11 07:38:38 UTC) #2

Message was sent while issue was closed.

Patch set 2 LGTM.

Expand All Messages | Collapse All Messages