Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(327)

Issue 2846041: code review 2846041: release.2010-11-02 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by adg
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, gri, r2, r
Visibility:
Public.

Description

release.2010-11-02

Patch Set 1 #

Patch Set 2 : code review 2846041: release.2010-11-02 #

Patch Set 3 : code review 2846041: release.2010-11-02 #

Patch Set 4 : code review 2846041: release.2010-11-02 #

Patch Set 5 : code review 2846041: release.2010-11-02 #

Patch Set 6 : code review 2846041: release.2010-11-02 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M .hgtags View 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/release.html View 1 2 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 7
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change.
12 years, 1 month ago (2010-11-03 00:12:57 UTC) #1
gri
FYI: There are several other files where vector was eliminated as well, not just regexp ...
12 years, 1 month ago (2010-11-03 00:21:36 UTC) #2
adg
I actually had the separate item * src: use append where appropriate. I just missed ...
12 years, 1 month ago (2010-11-03 00:25:42 UTC) #3
r2
the effective go entry should say "a few words about ..."
12 years, 1 month ago (2010-11-03 00:28:21 UTC) #4
adg
Hello golang-dev@googlegroups.com, gri, r2 (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 1 month ago (2010-11-03 00:38:51 UTC) #5
r
LGTM
12 years, 1 month ago (2010-11-03 00:46:24 UTC) #6
adg
12 years, 1 month ago (2010-11-03 00:49:28 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=c627e23260c7 ***

release.2010-11-02

R=golang-dev, gri, r2, r
CC=golang-dev
http://codereview.appspot.com/2846041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b