code review 2846041: release.2010-11-02

release.2010-11-02

[adg, 2010-11-03 00:12:57]

Hello golang-dev@googlegroups.com,

I'd like you to review this change.

[gri, 2010-11-03 00:21:36]

FYI: There are several other files where vector was eliminated as well, not
just regexp (all my submits with the text "use append"). Perhaps just say
"use append instead of vector in many packages".
- gri

On Tue, Nov 2, 2010 at 5:12 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change.
>
>
> Description:
> release.2010-11-02
>
> Please review this at http://codereview.appspot.com/2846041/
>
> Affected files:
>  M .hgtags
>  M doc/devel/release.html
>
>
> Index: .hgtags
> ===================================================================
> --- a/.hgtags
> +++ b/.hgtags
> @@ -36,4 +36,3 @@
>  ca4f9687cec0b9c4732afd57b8c2786c7fe242de release.2010-10-13.1
>  79997f0e5823ee9d13a34ca9971a9d8811df1c4a release.2010-10-20
>  4d5b0816392116d3a3452bb275b6dab6c6456278 release.2010-10-27
> -4d5b0816392116d3a3452bb275b6dab6c6456278 release
> Index: doc/devel/release.html
> ===================================================================
> --- a/doc/devel/release.html
> +++ b/doc/devel/release.html
> @@ -5,6 +5,44 @@
>  <p>This page summarizes the changes between tagged releases of Go.
>  For full details, see the <a href="
> http://code.google.com/p/go/source/list">Mercurial change log</a>.</p>
>
> +<h3 id="2010-11-02">2010-11-02</h3>
> +
> +<pre>
> +This release includes a language change: the new built-in function,
> append.
> +Append makes growing slices much simpler. See the spec for details:
> +        http://golang.org/doc/go_spec.html#Appending_and_copying_slices
> +
> +Other changes:
> +* 8l: pe generation fixes (thanks Alex Brainman).
> +* doc: Effective Go: append and a few words about append.
> +* build: fiddle with make variables.
> +* codereview: fix sync and download in Python 2.7 (thanks Fazlul
> Shahriar).
> +* debug/pe, cgo: add windows support (thanks Wei Guangjing <
> vcc.163@gmail.com>).
> +* go/ast: add Inspect function for easy AST inspection w/o a visitor.
> +* go/printer: do not remove parens around composite literals starting with
> +        a type name in control clauses.
> +* go/scanner: bug fixes, revisions, and more tests.
> +* gob: several fixes and documentation updates.
> +* godoc: bug fix (bug introduced with revision 3ee58453e961).
> +* gotest: print empty benchmark list in a way that gofmt will leave alone.
> +* http server: correctly respond with 304 NotModified (thanks Michael
> Hoisie).
> +* kate: update list of builtins (thanks Evan Shaw).
> +* libutf: update to Unicode 5.2.0 to match pkg/unicode (thanks Anthony
> Martin).
> +* misc/bbedit: update list of builtins (thanks Anthony Starks).
> +* misc/vim: update list of builtins.
> +* mkrunetype: install a Makefile and tweak it slightly so it can be built.
> +* netchan: fix locking bug.
> +* pidigits: minor improvements (thanks Evan Shaw).
> +* regexp: eliminate vector in favor of append.
> +* rpc: fix client deadlock bug.
> +* src: use append where appropriate.
> +* strings: add Contains helper function (thanks Brad Fitzpatrick).
> +* syscall: SIO constants for Linux (thanks Albert Strasheim),
> +        Stat(path) on windows (thanks Alex Brainman).
> +* test/ken/convert.go: add conversion torture test.
> +* testing: add Benchmark (thanks Roger Peppe).
> +</pre>
> +
>  <h3 id="2010-10-27">2010-10-27</h3>
>
>  <pre>
>
>
>

[adg, 2010-11-03 00:25:42]

I actually had the separate item

* src: use append where appropriate.

I just missed removing the regexp entry. I have updated the list.

On 3 November 2010 11:21, Robert Griesemer <gri@golang.org> wrote:
> FYI: There are several other files where vector was eliminated as well, not
> just regexp (all my submits with the text "use append"). Perhaps just say
> "use append instead of vector in many packages".
> - gri
>
> On Tue, Nov 2, 2010 at 5:12 PM, <adg@golang.org> wrote:
>>
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change.
>>
>>
>> Description:
>> release.2010-11-02
>>
>> Please review this at http://codereview.appspot.com/2846041/
>>
>> Affected files:
>>  M .hgtags
>>  M doc/devel/release.html
>>
>>
>> Index: .hgtags
>> ===================================================================
>> --- a/.hgtags
>> +++ b/.hgtags
>> @@ -36,4 +36,3 @@
>>  ca4f9687cec0b9c4732afd57b8c2786c7fe242de release.2010-10-13.1
>>  79997f0e5823ee9d13a34ca9971a9d8811df1c4a release.2010-10-20
>>  4d5b0816392116d3a3452bb275b6dab6c6456278 release.2010-10-27
>> -4d5b0816392116d3a3452bb275b6dab6c6456278 release
>> Index: doc/devel/release.html
>> ===================================================================
>> --- a/doc/devel/release.html
>> +++ b/doc/devel/release.html
>> @@ -5,6 +5,44 @@
>>  <p>This page summarizes the changes between tagged releases of Go.
>>  For full details, see the <a
>> href="http://code.google.com/p/go/source/list">Mercurial change log</a>.</p>
>>
>> +<h3 id="2010-11-02">2010-11-02</h3>
>> +
>> +<pre>
>> +This release includes a language change: the new built-in function,
>> append.
>> +Append makes growing slices much simpler. See the spec for details:
>> +        http://golang.org/doc/go_spec.html#Appending_and_copying_slices
>> +
>> +Other changes:
>> +* 8l: pe generation fixes (thanks Alex Brainman).
>> +* doc: Effective Go: append and a few words about append.
>> +* build: fiddle with make variables.
>> +* codereview: fix sync and download in Python 2.7 (thanks Fazlul
>> Shahriar).
>> +* debug/pe, cgo: add windows support (thanks Wei Guangjing
>> <vcc.163@gmail.com>).
>> +* go/ast: add Inspect function for easy AST inspection w/o a visitor.
>> +* go/printer: do not remove parens around composite literals starting
>> with
>> +        a type name in control clauses.
>> +* go/scanner: bug fixes, revisions, and more tests.
>> +* gob: several fixes and documentation updates.
>> +* godoc: bug fix (bug introduced with revision 3ee58453e961).
>> +* gotest: print empty benchmark list in a way that gofmt will leave
>> alone.
>> +* http server: correctly respond with 304 NotModified (thanks Michael
>> Hoisie).
>> +* kate: update list of builtins (thanks Evan Shaw).
>> +* libutf: update to Unicode 5.2.0 to match pkg/unicode (thanks Anthony
>> Martin).
>> +* misc/bbedit: update list of builtins (thanks Anthony Starks).
>> +* misc/vim: update list of builtins.
>> +* mkrunetype: install a Makefile and tweak it slightly so it can be
>> built.
>> +* netchan: fix locking bug.
>> +* pidigits: minor improvements (thanks Evan Shaw).
>> +* regexp: eliminate vector in favor of append.
>> +* rpc: fix client deadlock bug.
>> +* src: use append where appropriate.
>> +* strings: add Contains helper function (thanks Brad Fitzpatrick).
>> +* syscall: SIO constants for Linux (thanks Albert Strasheim),
>> +        Stat(path) on windows (thanks Alex Brainman).
>> +* test/ken/convert.go: add conversion torture test.
>> +* testing: add Benchmark (thanks Roger Peppe).
>> +</pre>
>> +
>>  <h3 id="2010-10-27">2010-10-27</h3>
>>
>>  <pre>
>>
>>
>
>

[r2, 2010-11-03 00:28:21]

the effective go entry should say "a few words about ..."

[adg, 2010-11-03 00:38:51]

Hello golang-dev@googlegroups.com, gri, r2 (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2010-11-03 00:46:24]

LGTM

[adg, 2010-11-03 00:49:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=c627e23260c7 ***

release.2010-11-02

R=golang-dev, gri, r2, r
CC=golang-dev
http://codereview.appspot.com/2846041