Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(173)

Issue 284530043: Introduce the traffic control layer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by Stefano Avallone
Modified:
6 years, 2 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Introduce the traffic control layer

Patch Set 1 #

Total comments: 120

Patch Set 2 : Address the first round of comments #

Patch Set 3 : Use DoInitialize to check config and initialize queue discs #

Total comments: 11
Unified diffs Side-by-side diffs Delta from patch set Stats (+10628 lines, -3915 lines) Patch
M doc/main.h View 1 chunk +1 line, -0 lines 0 comments Download
M doc/models/Makefile View 5 chunks +10 lines, -1 line 0 comments Download
M doc/models/source/index.rst View 1 chunk +1 line, -0 lines 0 comments Download
M doc/models/source/internet-models.rst View 1 chunk +0 lines, -1 line 0 comments Download
A doc/models/source/traffic-control.rst View 1 chunk +10 lines, -0 lines 0 comments Download
M examples/tcp/tcp-variants-comparison.cc View 1 6 chunks +27 lines, -42 lines 0 comments Download
A examples/traffic-control/traffic-control.cc View 1 1 chunk +143 lines, -0 lines 0 comments Download
A examples/traffic-control/wscript View 1 chunk +6 lines, -0 lines 0 comments Download
M src/csma/model/csma-net-device.cc View 1 5 chunks +20 lines, -9 lines 0 comments Download
M src/fd-net-device/model/fd-net-device.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download
R src/internet/doc/codel.rst View 1 chunk +0 lines, -134 lines 0 comments Download
R src/internet/examples/codel-vs-droptail-asymmetric.cc View 1 chunk +0 lines, -435 lines 0 comments Download
R src/internet/examples/codel-vs-droptail-basic-test.cc View 1 chunk +0 lines, -219 lines 0 comments Download
M src/internet/examples/wscript View 1 chunk +0 lines, -8 lines 0 comments Download
M src/internet/helper/internet-stack-helper.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/internet/helper/ipv4-address-helper.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M src/internet/helper/ipv6-address-helper.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M src/internet/model/arp-cache.h View 6 chunks +10 lines, -4 lines 0 comments Download
M src/internet/model/arp-cache.cc View 1 3 chunks +11 lines, -8 lines 0 comments Download
M src/internet/model/arp-l3-protocol.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/internet/model/arp-l3-protocol.cc View 6 chunks +12 lines, -8 lines 0 comments Download
R src/internet/model/codel-queue.h View 1 chunk +0 lines, -251 lines 0 comments Download
R src/internet/model/codel-queue.cc View 1 chunk +0 lines, -606 lines 0 comments Download
M src/internet/model/icmpv6-l4-protocol.h View 7 chunks +7 lines, -6 lines 0 comments Download
M src/internet/model/icmpv6-l4-protocol.cc View 17 chunks +27 lines, -36 lines 0 comments Download
M src/internet/model/ipv4-interface.h View 1 5 chunks +10 lines, -2 lines 0 comments Download
M src/internet/model/ipv4-interface.cc View 1 7 chunks +27 lines, -15 lines 0 comments Download
M src/internet/model/ipv4-l3-protocol.h View 1 3 chunks +21 lines, -2 lines 0 comments Download
M src/internet/model/ipv4-l3-protocol.cc View 1 11 chunks +49 lines, -39 lines 0 comments Download
A src/internet/model/ipv4-packet-filter.h View 1 1 chunk +159 lines, -0 lines 0 comments Download
A src/internet/model/ipv4-packet-filter.cc View 1 1 chunk +193 lines, -0 lines 0 comments Download
A src/internet/model/ipv4-queue-disc-item.h View 1 chunk +99 lines, -0 lines 0 comments Download
A src/internet/model/ipv4-queue-disc-item.cc View 1 1 chunk +82 lines, -0 lines 0 comments Download
M src/internet/model/ipv6-extension.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/internet/model/ipv6-extension.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/internet/model/ipv6-interface.h View 1 5 chunks +15 lines, -2 lines 0 comments Download
M src/internet/model/ipv6-interface.cc View 1 7 chunks +25 lines, -9 lines 0 comments Download
M src/internet/model/ipv6-l3-protocol.h View 1 2 chunks +13 lines, -0 lines 0 comments Download
M src/internet/model/ipv6-l3-protocol.cc View 1 7 chunks +33 lines, -20 lines 0 comments Download
A src/internet/model/ipv6-packet-filter.h View 1 1 chunk +107 lines, -0 lines 0 comments Download
A src/internet/model/ipv6-packet-filter.cc View 1 1 chunk +143 lines, -0 lines 0 comments Download
A src/internet/model/ipv6-queue-disc-item.h View 1 chunk +99 lines, -0 lines 0 comments Download
A src/internet/model/ipv6-queue-disc-item.cc View 1 1 chunk +82 lines, -0 lines 0 comments Download
M src/internet/model/ndisc-cache.h View 6 chunks +11 lines, -5 lines 0 comments Download
M src/internet/model/ndisc-cache.cc View 1 6 chunks +22 lines, -16 lines 0 comments Download
R src/internet/test/codel-queue-test-suite.cc View 1 chunk +0 lines, -523 lines 0 comments Download
M src/internet/test/ipv4-forwarding-test.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M src/internet/test/ipv4-header-test.cc View 7 chunks +10 lines, -6 lines 0 comments Download
M src/internet/test/ipv4-packet-info-tag-test-suite.cc View 5 chunks +7 lines, -3 lines 0 comments Download
M src/internet/test/ipv6-dual-stack-test-suite.cc View 3 chunks +6 lines, -1 line 0 comments Download
M src/internet/test/ipv6-fragmentation-test.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/internet/test/ipv6-packet-info-tag-test-suite.cc View 6 chunks +9 lines, -4 lines 0 comments Download
M src/internet/test/tcp-test.cc View 9 chunks +15 lines, -8 lines 0 comments Download
M src/internet/wscript View 8 chunks +9 lines, -4 lines 0 comments Download
M src/network/doc/queue.rst View 6 chunks +15 lines, -63 lines 0 comments Download
R src/network/examples/droptail_vs_red.cc View 1 chunk +0 lines, -163 lines 0 comments Download
R src/network/examples/red-tests.cc View 1 chunk +0 lines, -467 lines 0 comments Download
M src/network/examples/wscript View 1 chunk +0 lines, -6 lines 0 comments Download
M src/network/model/net-device.h View 1 5 chunks +138 lines, -0 lines 0 comments Download
M src/network/model/net-device.cc View 1 3 chunks +137 lines, -0 lines 0 comments Download
M src/network/test/drop-tail-queue-test-suite.cc View 1 chunk +16 lines, -16 lines 0 comments Download
M src/network/test/examples-to-run.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
R src/network/test/red-queue-test-suite.cc View 1 chunk +0 lines, -281 lines 0 comments Download
M src/network/utils/drop-tail-queue.h View 2 chunks +7 lines, -28 lines 0 comments Download
M src/network/utils/drop-tail-queue.cc View 3 chunks +17 lines, -88 lines 0 comments Download
M src/network/utils/queue.h View 7 chunks +157 lines, -31 lines 0 comments Download
M src/network/utils/queue.cc View 8 chunks +181 lines, -18 lines 0 comments Download
R src/network/utils/red-queue.h View 1 chunk +0 lines, -285 lines 0 comments Download
M src/network/utils/simple-net-device.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/network/wscript View 3 chunks +0 lines, -3 lines 0 comments Download
M src/point-to-point/model/point-to-point-net-device.cc View 1 6 chunks +34 lines, -11 lines 0 comments Download
M src/spectrum/model/aloha-noack-net-device.cc View 1 3 chunks +15 lines, -6 lines 0 comments Download
M src/test/ns3tcp/ns3tcp-state-test-suite.cc View 1 chunk +1 line, -1 line 0 comments Download
A src/traffic-control/doc/classful-queue-disc.dia View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/traffic-control/doc/codel.rst View 1 1 chunk +140 lines, -0 lines 0 comments Download
A src/traffic-control/doc/multi-queue-aware-queue-disc.dia View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/traffic-control/doc/pfifo-fast.rst View 1 1 chunk +58 lines, -0 lines 0 comments Download
A src/traffic-control/doc/queue-discs.rst View 1 1 chunk +210 lines, -0 lines 0 comments Download
A src/traffic-control/doc/red.rst View 1 1 chunk +67 lines, -0 lines 0 comments Download
A src/traffic-control/doc/traffic-control-layer.rst View 1 1 chunk +127 lines, -0 lines 0 comments Download
A src/traffic-control/examples/codel-vs-pfifo-asymmetric.cc View 1 1 chunk +447 lines, -0 lines 0 comments Download
A src/traffic-control/examples/codel-vs-pfifo-basic-test.cc View 1 1 chunk +223 lines, -0 lines 0 comments Download
A src/traffic-control/examples/pfifo-vs-red.cc View 1 1 chunk +186 lines, -0 lines 8 comments Download
A src/traffic-control/examples/red-tests.cc View 1 1 chunk +478 lines, -0 lines 0 comments Download
A src/traffic-control/examples/wscript View 1 chunk +17 lines, -0 lines 0 comments Download
A src/traffic-control/helper/queue-disc-container.h View 1 1 chunk +171 lines, -0 lines 0 comments Download
A src/traffic-control/helper/queue-disc-container.cc View 1 1 chunk +73 lines, -0 lines 0 comments Download
A src/traffic-control/helper/traffic-control-helper.h View 1 1 chunk +462 lines, -0 lines 0 comments Download
A src/traffic-control/helper/traffic-control-helper.cc View 1 1 chunk +392 lines, -0 lines 0 comments Download
A src/traffic-control/model/codel-queue-disc.h View 1 2 1 chunk +251 lines, -0 lines 0 comments Download
A src/traffic-control/model/codel-queue-disc.cc View 1 1 chunk +646 lines, -0 lines 0 comments Download
A src/traffic-control/model/packet-filter.h View 1 1 chunk +69 lines, -0 lines 0 comments Download
A src/traffic-control/model/packet-filter.cc View 1 chunk +63 lines, -0 lines 0 comments Download
A src/traffic-control/model/pfifo-fast-queue-disc.h View 1 2 1 chunk +85 lines, -0 lines 0 comments Download
A src/traffic-control/model/pfifo-fast-queue-disc.cc View 1 1 chunk +200 lines, -0 lines 0 comments Download
A src/traffic-control/model/queue-disc.h View 1 2 1 chunk +552 lines, -0 lines 0 comments Download
A src/traffic-control/model/queue-disc.cc View 1 2 1 chunk +590 lines, -0 lines 0 comments Download
A src/traffic-control/model/red-queue-disc.h View 1 2 1 chunk +287 lines, -0 lines 0 comments Download
A src/traffic-control/model/red-queue-disc.cc View 1 1 chunk +702 lines, -0 lines 0 comments Download
A src/traffic-control/model/traffic-control-layer.h View 1 2 1 chunk +222 lines, -0 lines 0 comments Download
A src/traffic-control/model/traffic-control-layer.cc View 1 2 1 chunk +292 lines, -0 lines 0 comments Download
A src/traffic-control/test/codel-queue-disc-test-suite.cc View 1 2 1 chunk +543 lines, -0 lines 0 comments Download
A src/traffic-control/test/pfifo-fast-queue-disc-test-suite.cc View 1 1 chunk +364 lines, -0 lines 0 comments Download
A src/traffic-control/test/red-queue-disc-test-suite.cc View 1 2 1 chunk +296 lines, -0 lines 3 comments Download
A src/traffic-control/wscript View 1 chunk +46 lines, -0 lines 0 comments Download
M src/wifi/model/regular-wifi-mac.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/wifi/model/regular-wifi-mac.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-mac.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-net-device.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/wimax/model/bs-net-device.cc View 1 2 chunks +15 lines, -3 lines 0 comments Download
M src/wimax/model/ss-net-device.cc View 1 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 21
Tom Henderson
I haven't reviewed all files, but I agree with the overall approach and think it ...
6 years, 3 months ago (2016-02-17 06:28:18 UTC) #1
Tommaso Pecorella
A couple of comments before starting to dissect the code. 1) The DropTailQueue seems to ...
6 years, 3 months ago (2016-02-17 20:54:21 UTC) #2
Stefano Avallone
Tom, thanks a lot for the review. On 2016/02/17 06:28:18, Tom Henderson wrote: > I ...
6 years, 3 months ago (2016-02-17 22:50:05 UTC) #3
Stefano Avallone
https://codereview.appspot.com/284530043/diff/1/examples/traffic-control/traffic-control.cc File examples/traffic-control/traffic-control.cc (right): https://codereview.appspot.com/284530043/diff/1/examples/traffic-control/traffic-control.cc#newcode29 examples/traffic-control/traffic-control.cc:29: // This simple example shows how to use TrafficContorlHelper ...
6 years, 3 months ago (2016-02-17 22:50:43 UTC) #4
Stefano Avallone
Tommaso, thanks a lot for the review. On 2016/02/17 20:54:21, Tommaso Pecorella wrote: > A ...
6 years, 3 months ago (2016-02-17 23:57:52 UTC) #5
Tommaso Pecorella
On 2016/02/17 23:57:52, Stefano Avallone wrote: > Tommaso, > > thanks a lot for the ...
6 years, 3 months ago (2016-02-18 00:00:36 UTC) #6
Tommaso Pecorella
Second batch of comments (still very partial). More tomorrow. https://codereview.appspot.com/284530043/diff/1/examples/traffic-control/traffic-control.cc File examples/traffic-control/traffic-control.cc (right): https://codereview.appspot.com/284530043/diff/1/examples/traffic-control/traffic-control.cc#newcode98 examples/traffic-control/traffic-control.cc:98: ...
6 years, 3 months ago (2016-02-18 00:01:19 UTC) #7
Stefano Avallone
Patch set 2 is the latest version taking into account Tom's and Tommaso's recent comments. ...
6 years, 3 months ago (2016-02-18 00:03:18 UTC) #8
Stefano Avallone
https://codereview.appspot.com/284530043/diff/1/examples/traffic-control/traffic-control.cc File examples/traffic-control/traffic-control.cc (right): https://codereview.appspot.com/284530043/diff/1/examples/traffic-control/traffic-control.cc#newcode98 examples/traffic-control/traffic-control.cc:98: onoff.SetAttribute ("DataRate", DataRateValue (1000000000)); //bit/s On 2016/02/18 00:01:18, Tommaso ...
6 years, 3 months ago (2016-02-18 16:44:28 UTC) #9
Tom Henderson
On 2016/02/17 22:50:05, Stefano Avallone wrote: > Tom, thanks a lot for the review. > ...
6 years, 3 months ago (2016-02-18 17:18:38 UTC) #10
Stefano Avallone
On Thu, Feb 18, 2016 at 6:18 PM, <tomh.org@gmail.com> wrote: > > It seems to ...
6 years, 3 months ago (2016-02-18 17:39:44 UTC) #11
Stefano Avallone
https://codereview.appspot.com/284530043/diff/1/src/traffic-control/doc/queue-discs.rst File src/traffic-control/doc/queue-discs.rst (right): https://codereview.appspot.com/284530043/diff/1/src/traffic-control/doc/queue-discs.rst#newcode15 src/traffic-control/doc/queue-discs.rst:15: A netdevice can have a single (root) queue disc ...
6 years, 3 months ago (2016-02-18 18:12:46 UTC) #12
Stefano Avallone
On Thu, Feb 18, 2016 at 6:18 PM, <tomh.org@gmail.com> wrote: > It seems to me ...
6 years, 3 months ago (2016-02-18 22:26:37 UTC) #13
Tommaso Pecorella
Here's the second (and last) batch of comments. Cheers, T. https://codereview.appspot.com/284530043/diff/1/src/internet/helper/internet-stack-helper.cc File src/internet/helper/internet-stack-helper.cc (right): https://codereview.appspot.com/284530043/diff/1/src/internet/helper/internet-stack-helper.cc#newcode500 ...
6 years, 3 months ago (2016-02-19 00:51:14 UTC) #14
Tom Henderson
On 2016/02/18 22:26:37, Stefano Avallone wrote: > On Thu, Feb 18, 2016 at 6:18 PM, ...
6 years, 3 months ago (2016-02-19 14:40:45 UTC) #15
Stefano Avallone
https://codereview.appspot.com/284530043/diff/1/src/internet/helper/internet-stack-helper.cc File src/internet/helper/internet-stack-helper.cc (right): https://codereview.appspot.com/284530043/diff/1/src/internet/helper/internet-stack-helper.cc#newcode500 src/internet/helper/internet-stack-helper.cc:500: } Yes, this is something I noticed and didn't ...
6 years, 2 months ago (2016-02-21 23:25:58 UTC) #16
Mohit P. Tahiliani
Hi, I found some places where we can use "queue disc" instead of "queue". May ...
6 years, 2 months ago (2016-02-25 15:05:09 UTC) #17
Stefano Avallone
https://codereview.appspot.com/284530043/diff/110001/src/traffic-control/examples/pfifo-vs-red.cc File src/traffic-control/examples/pfifo-vs-red.cc (right): https://codereview.appspot.com/284530043/diff/110001/src/traffic-control/examples/pfifo-vs-red.cc#newcode56 src/traffic-control/examples/pfifo-vs-red.cc:56: cmd.AddValue ("queueDiscType", "Set Queue type to PfifoFast or RED", ...
6 years, 2 months ago (2016-02-25 17:59:34 UTC) #18
Mohit P. Tahiliani
Hi, I came across this doubt. Can you please check? Thanks and Regards, Mohit P. ...
6 years, 2 months ago (2016-03-03 04:53:45 UTC) #19
Stefano Avallone
https://codereview.appspot.com/284530043/diff/110001/src/traffic-control/test/red-queue-disc-test-suite.cc File src/traffic-control/test/red-queue-disc-test-suite.cc (right): https://codereview.appspot.com/284530043/diff/110001/src/traffic-control/test/red-queue-disc-test-suite.cc#newcode80 src/traffic-control/test/red-queue-disc-test-suite.cc:80: queue->SetTh (minTh * pktSize, maxTh * pktSize); I think ...
6 years, 2 months ago (2016-03-03 08:49:53 UTC) #20
Stefano Avallone
6 years, 2 months ago (2016-03-03 08:59:34 UTC) #21
https://codereview.appspot.com/284530043/diff/110001/src/traffic-control/test...
File src/traffic-control/test/red-queue-disc-test-suite.cc (right):

https://codereview.appspot.com/284530043/diff/110001/src/traffic-control/test...
src/traffic-control/test/red-queue-disc-test-suite.cc:80: queue->SetTh (minTh *
pktSize, maxTh * pktSize);
Fixed on my queue-disc-ndq-aggr branch. Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b