Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1192)

Issue 28440043: Send the bundle ID when deploying.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by bac
Modified:
10 years, 5 months ago
Reviewers:
jeff.pihach, mp+195598
Visibility:
Public.

Description

Send the bundle ID when deploying. By sending the bundle ID to the server, the deployment statistics can be updated on Charmworld for that bundle. QA: In the latest charm trunk: % juju switch ec2 % juju bootstrap % make deploy % juju set juju-gui "juju-gui-source=lp:~bac/juju-gui/send-bundle-id-to-deployer" % juju set juju-gui "charmworld-url=http://staging.jujucharms.com" Search for a simple bundle. Jorge's are good. In this example I'll use mediawiki-simple. Look at the bundle on staging: http://staging.jujucharms.com/bundle/~jorge/mediawiki-simple/mediawiki-simple Note the Downloads statistics. Go to your juju-gui instance on ec2. Search for jorge. Pick the bundle you want (mediawiki-simple in this case). Deploy it. Only when all service are successfully deployed, green, and relations built will the deployment statistics get updated. At that time go back to staging and see that the downloads have been incremented. https://code.launchpad.net/~bac/juju-gui/send-bundle-id-to-deployer/+merge/195598 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Send the bundle ID when deploying. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -21 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 chunk +2 lines, -1 line 0 comments Download
M app/assets/javascripts/bundle-import-helpers.js View 1 3 chunks +9 lines, -3 lines 0 comments Download
M app/store/env/go.js View 1 1 chunk +11 lines, -7 lines 0 comments Download
M app/subapps/browser/views/bundle.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_bundle_import_helpers.js View 1 6 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 3
bac
Please take a look.
10 years, 5 months ago (2013-11-18 15:36:37 UTC) #1
jeff.pihach
LGTM Thanks for the discussion on this! You can either do the comment below or ...
10 years, 5 months ago (2013-11-18 15:39:44 UTC) #2
bac
10 years, 5 months ago (2013-11-18 18:32:00 UTC) #3
*** Submitted:

Send the bundle ID when deploying.

By sending the bundle ID to the server, the deployment statistics can be
updated on Charmworld for that bundle.

QA:

In the latest charm trunk:
% juju switch ec2
% juju bootstrap
% make deploy
% juju set juju-gui
"juju-gui-source=lp:~bac/juju-gui/send-bundle-id-to-deployer"
% juju set juju-gui "charmworld-url=http://staging.jujucharms.com"

Search for a simple bundle.  Jorge's are good.  In this example I'll use
mediawiki-simple.

Look at the bundle on staging:
http://staging.jujucharms.com/bundle/~jorge/mediawiki-simple/mediawiki-simple

Note the Downloads statistics.

Go to your juju-gui instance on ec2.
Search for jorge.
Pick the bundle you want (mediawiki-simple in this case).
Deploy it.
Only when all service are successfully deployed, green, and relations built
will the deployment statistics get updated.  At that time go back to staging
and see that the downloads have been incremented.

R=jeff.pihach
CC=
https://codereview.appspot.com/28440043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b