Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3889)

Issue 284340043: Fix Dr. Heapstat documentation build error

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by zhaoqin
Modified:
8 years, 3 months ago
Reviewers:
bruening
CC:
drmemory-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- Fix Dr. Heapstat documentation build error - remove reference from drfuzz.dox to page_fuzzer because page_fuzzer is build on Dr. Memory only ---------------

Patch Set 1 #

Patch Set 2 : update review email #

Total comments: 2

Patch Set 3 : PTAL #

Patch Set 4 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M docs/CMake_doxyfile.cmake View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M drfuzz/drfuzz.dox View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7
zhaoqin
8 years, 3 months ago (2016-01-25 19:30:37 UTC) #1
zhaoqin
Commit log for latest patchset: --------------- Fix Dr. Heapstat documentation build error - remove reference ...
8 years, 3 months ago (2016-01-25 20:15:19 UTC) #2
bruening
https://codereview.appspot.com/284340043/diff/20001/drfuzz/drfuzz.dox File drfuzz/drfuzz.dox (left): https://codereview.appspot.com/284340043/diff/20001/drfuzz/drfuzz.dox#oldcode40 drfuzz/drfuzz.dox:40: implement the Dr. Memory \ref page_fuzzer. Can we have ...
8 years, 3 months ago (2016-01-25 20:28:05 UTC) #3
zhaoqin
https://codereview.appspot.com/284340043/diff/20001/drfuzz/drfuzz.dox File drfuzz/drfuzz.dox (left): https://codereview.appspot.com/284340043/diff/20001/drfuzz/drfuzz.dox#oldcode40 drfuzz/drfuzz.dox:40: implement the Dr. Memory \ref page_fuzzer. On 2016/01/25 20:28:05, ...
8 years, 3 months ago (2016-01-25 21:16:55 UTC) #4
zhaoqin
Commit log for latest patchset: --------------- Fix Dr. Heapstat documentation build error - add conditional ...
8 years, 3 months ago (2016-01-25 21:23:11 UTC) #5
bruening
It seems better to exclude the whole sentence but like you said if doxygen is ...
8 years, 3 months ago (2016-01-25 21:44:58 UTC) #6
zhaoqin
8 years, 3 months ago (2016-01-25 22:40:47 UTC) #7
Committed as
https://github.com/DynamoRIO/drmemory/commit/8bf3c135b5e165817a3e144130f65562...

Final commit log: 
---------------
Fix Dr. Heapstat documentation build error

- add conditional reference from drfuzz.dox to page_fuzzer
  because page_fuzzer is build on Dr. Memory only

Review-URL: https://codereview.appspot.com/284340043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b