fixed READ/WRITE_TLS_SLOT bug on ARM

Commit log for first patchset:
---------------
fixed READ/WRITE_TLS_SLOT bug on ARM

- change 'idx * sizeof(var)' to 'idx' in READ/WRITE_TLS_SLOT because idx
  is actually the offset
---------------

[bruening, 2016-01-04 18:09:12]

Please change the variable name to "offs", as your fix looks wrong with the name
"idx".

Why didn't we notice this before?  Is this code really not used for much?

Otherwise LGTM

https://codereview.appspot.com/284080043/diff/1/core/unix/os.c
File core/unix/os.c (right):

https://codereview.appspot.com/284080043/diff/1/core/unix/os.c#newcode1309
core/unix/os.c:1309: # define WRITE_TLS_SLOT(idx, var)            \
s/idx/offs/

https://codereview.appspot.com/284080043/diff/1/core/unix/os.c#newcode1316
core/unix/os.c:1316: # define READ_TLS_SLOT(idx, var)          \
s/idx/offs/

And in any other related macros here

[zhaoqin, 2016-01-05 16:30:57]

Commit log for latest patchset:
---------------
fixed READ/WRITE_TLS_SLOT bug on ARM

- rename idx to offs in READ/WRITE_TLS_SLOT macros
- change 'offs * sizeof(var)' to 'offs' in READ/WRITE_TLS_SLOT

Review-URL: https://codereview.appspot.com/284080043
---------------

[bruening, 2016-01-05 16:36:46]

On Tue, Jan 5, 2016 at 11:30 AM, <reply@codereview-hr.appspotmail.com>
wrote:

> - rename idx to offs in READ/WRITE_TLS_SLOT macros
> - change 'offs * sizeof(var)' to 'offs' in READ/WRITE_TLS_SLOT
>

Kind of confusing: you mean "change 'idx * sizeof(var)' to 'offs'"

[zhaoqin, 2016-01-05 16:57:10]

Committed as
https://github.com/DynamoRIO/dynamorio/commit/b914e5dadcbcc0cd937a63a1ad82f72...

Final commit log: 
---------------
fixed READ/WRITE_TLS_SLOT bug on ARM

- rename idx to offs in READ/WRITE_TLS_SLOT macros
- change 'idx * sizeof(var)' to 'offs' in READ/WRITE_TLS_SLOT

Review-URL: https://codereview.appspot.com/284080043
---------------