Issue 283280043: [dfvfs] Added XZ and LZMA compressed stream support #84

Issue 283280043: [dfvfs] Added XZ and LZMA compressed stream support #84 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by Joachim Metz

Modified:
10 years, 1 month ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Added XZ and LZMA compressed stream support #84 TODO: * Add python-lzma to l2tbinaries

Patch Set 1 : Worked on XZ and LZMA compressed stream support #84 #

Patch Set 2 : Worked on XZ and LZMA compressed stream support #84 #

Total comments: 2

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+297 lines, -16 lines)			Patch
M	.travis.yml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	config/dpkg/control	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	dfvfs/analyzer/bzip2_analyzer_helper.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	dfvfs/compression/__init__.py	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	dfvfs/compression/bzip2_decompressor.py	View		4 chunks	+6 lines, -7 lines	0 comments	Download
A	dfvfs/compression/xz_decompressor.py	View	1	1 chunk	+74 lines, -0 lines	2 comments	Download
M	dfvfs/compression/zlib_decompressor.py	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	dfvfs/dependencies.py	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	dfvfs/lib/definitions.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	setup.cfg	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	setup.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	test_data/syslog.lzma	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	test_data/syslog.xz	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tests/compression/bzip2_decompressor.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A	tests/compression/xz_decompressor.py	View	1	1 chunk	+72 lines, -0 lines	0 comments	Download
M	tests/file_io/compressed_stream_io.py	View	1	3 chunks	+121 lines, -2 lines	0 comments	Download
M	tests/helpers/file_system_searcher.py	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	tox.ini	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

Joachim Metz

PTAL I had to make some changes to make XZ support optional for the time ...

10 years, 2 months ago (2016-02-21 08:18:33 UTC) #5

onager

Still LGTM, with one new docstring nit. https://codereview.appspot.com/283280043/diff/40001/dfvfs/compression/xz_decompressor.py File dfvfs/compression/xz_decompressor.py (right): https://codereview.appspot.com/283280043/diff/40001/dfvfs/compression/xz_decompressor.py#newcode6 dfvfs/compression/xz_decompressor.py:6: # Note ...

10 years, 1 month ago (2016-03-06 18:55:31 UTC) #6

Joachim Metz

Changes have been merged with master branch. To close the review and clean up the ...

10 years, 1 month ago (2016-03-06 19:09:43 UTC) #7

Joachim Metz

10 years, 1 month ago (2016-03-06 19:10:27 UTC) #8

Message was sent while issue was closed.

https://codereview.appspot.com/283280043/diff/40001/dfvfs/compression/xz_deco...
File dfvfs/compression/xz_decompressor.py (right):

https://codereview.appspot.com/283280043/diff/40001/dfvfs/compression/xz_deco...
dfvfs/compression/xz_decompressor.py:6: # Note we have to handle different
versions of the lzma code.
On 2016/03/06 18:55:31, onager wrote:
> Why?

Otherwise the code breaks ;) I've changed the comment a bit.

Expand All Messages | Collapse All Messages