Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5485)

Issue 283090043: i#1114 JIT optimization: generalize flush/synch with per-thread callback

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by Byron
Modified:
8 years, 3 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1114 JIT optimization: generalize flush/synch with per-thread callback Generalize the 3-stage synch/flush sequence by adding an alternative stage 1 that takes a callback function, which is invoked per thread after synch. ---------------

Patch Set 1 #

Total comments: 4

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -189 lines) Patch
M core/fragment.h View 4 chunks +57 lines, -8 lines 0 comments Download
M core/fragment.c View 1 8 chunks +232 lines, -181 lines 0 comments Download

Messages

Total messages: 4
Byron
8 years, 3 months ago (2016-01-20 12:17:19 UTC) #1
Byron
This CL mostly moves existing lines around to make the per-thread callback possible. It should ...
8 years, 3 months ago (2016-01-20 12:23:27 UTC) #2
bruening
The diff is not easy to read with all of the moved code so I ...
8 years, 3 months ago (2016-01-22 18:07:00 UTC) #3
Byron
8 years, 3 months ago (2016-01-24 11:12:47 UTC) #4
Committed as
https://github.com/DynamoRIO/dynamorio/commit/1445c54dac0628cc6cb729b2a9c8c86...

Final commit log: 
---------------
i#1114 JIT optimization: generalize flush/synch with per-thread callback

Generalize the 3-stage synch/flush sequence by adding
an alternative stage 1 that takes a callback function,
which is invoked per thread after synch.

Review-URL: https://codereview.appspot.com/283090043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b