Issue 2829041: Add JSONP support for REST and RPC API

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2829041: Add JSONP support for REST and RPC API

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by bashofmann

Modified:
15 years, 5 months ago

Reviewers:
plindner1

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

see https://issues.apache.org/jira/browse/SHINDIG-1459

Patch Set 1 #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+55 lines, -9 lines)			Patch
src/social/converters/OutputJsonConverter.php	View	2 chunks	+20 lines, -6 lines	0 comments	Download
src/social/servlet/JsonRpcServlet.php	View	3 chunks	+17 lines, -3 lines	0 comments	Download
test/social/OutputJsonConverterTest.php	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

plindner1

15 years, 5 months ago (2010-11-03 00:46:18 UTC) #2

Looks good.

I highly recommend validation of the callback parameter for security. If you do
not validate this could be used to execute arbitrary javascript in the user's
browser (callback=alert();test for example)

Expand All Messages | Collapse All Messages