Issue 282520043: TBR: i#1756 Android 6.0: fix two callstack quality problems

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 282520043: TBR: i#1756 Android 6.0: fix two callstack quality problems

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 2 months ago by bruening

Modified:
8 years, 2 months ago

Reviewers:
zhaoqin

CC:
drmemory-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1756 Android 6.0: fix two callstack quality problems Fixes two problems with callstacks that show up on Android 6.0: 1) Fix a bug in is_retaddr() for A32 OP_bl. 2) Add retaddr "zeroing" for the "pop bl;...;bx lr" pattern. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
	M	common/callstack.c	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	drmemory/instru.c	View		2 chunks	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

8 years, 2 months ago (2016-02-09 20:43:59 UTC) #2

Committed as
https://github.com/DynamoRIO/drmemory/commit/dcb4bf8d972407757a918d5341a6799e...

Final commit log: 
---------------
i#1756 Android 6.0: fix two callstack quality problems

Fixes two problems with callstacks that show up on Android 6.0:

1) Fix a bug in is_retaddr() for A32 OP_bl.

2) Add retaddr "zeroing" for the "pop bl;...;bx lr" pattern.

Review-URL: https://codereview.appspot.com/282520043
---------------

Expand All Messages | Collapse All Messages