Issue 282420043: Fix fuzz_corpus test failure on bot

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 282420043: Fix fuzz_corpus test failure on bot

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 3 months ago by zhaoqin

Modified:
8 years, 3 months ago

Reviewers:
bruening

CC:
drmemory-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- Fix fuzz_corpus test failure on bot - use function pointer to avoid fuzz target being inlined ---------------

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tests/fuzz/fuzz_corpus.c	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

8 years, 3 months ago (2016-01-29 23:02:07 UTC) #2

If comments are added then LGTM

https://codereview.appspot.com/282420043/diff/1/tests/fuzz/fuzz_corpus.c
File tests/fuzz/fuzz_corpus.c (right):

https://codereview.appspot.com/282420043/diff/1/tests/fuzz/fuzz_corpus.c#newc...
tests/fuzz/fuzz_corpus.c:70: int (*func_ptr)(int *, int) = argc > 2 ? NULL :
&DrMemFuzzFunc;
This must have a comment explaining: I'm wondering if the NULL crash is
deliberate, why a func ptr, etc.

Expand All Messages | Collapse All Messages