i#1114 JIT optimization: make red-black test client-only

Commit log for first patchset:
---------------
i#1114 JIT optimization: make red-black test client-only

The build fails for configurations not using the
client interface because the red-black unit test
uses some client API functions. This CL excludes
the red-black test from those builds.
---------------

[Byron, 2016-01-06 11:44:53]

https://codereview.appspot.com/282070043/diff/1/core/unit_tests.c
File core/unit_tests.c (right):

https://codereview.appspot.com/282070043/diff/1/core/unit_tests.c#newcode75
core/unit_tests.c:75: #ifdef CLIENT_INTERFACE
Even though the JIT optimization can be used in a non-client build, there's no
particular need to run the unit test for the red-black tree in those builds. Or
should I call the utils functions instead of the client interface?

[bruening, 2016-01-06 16:18:56]

https://codereview.appspot.com/282070043/diff/1/core/unit_tests.c
File core/unit_tests.c (right):

https://codereview.appspot.com/282070043/diff/1/core/unit_tests.c#newcode75
core/unit_tests.c:75: #ifdef CLIENT_INTERFACE
On 2016/01/06 11:44:53, Byron wrote:
> Even though the JIT optimization can be used in a non-client build, there's no
> particular need to run the unit test for the red-black tree in those builds.
Or
> should I call the utils functions instead of the client interface?

Yes, I would vote for using the internal routines and making all of this
internal code independent of the client interface.

[Byron, 2016-01-06 20:37:15]

Commit log for latest patchset:
---------------
i#1114 JIT optimization: remove client dependencies

Removes dependencies on the client interface
that were mistakenly used in the red-black tree
unit test. Using internal functions instead.

Review-URL: https://codereview.appspot.com/282070043
---------------

[Byron, 2016-01-06 20:38:57]

I guess that's the obvious thing to do :-)

https://codereview.appspot.com/282070043/diff/1/core/unit_tests.c
File core/unit_tests.c (right):

https://codereview.appspot.com/282070043/diff/1/core/unit_tests.c#newcode75
core/unit_tests.c:75: #ifdef CLIENT_INTERFACE
On 2016/01/06 16:18:56, bruening wrote:
> On 2016/01/06 11:44:53, Byron wrote:
> > Even though the JIT optimization can be used in a non-client build, there's
no
> > particular need to run the unit test for the red-black tree in those builds.
> Or
> > should I call the utils functions instead of the client interface?
> 
> Yes, I would vote for using the internal routines and making all of this
> internal code independent of the client interface.

Done.

[bruening, 2016-01-06 21:11:58]

LGTM

[Byron, 2016-01-06 22:26:39]

Committed as
https://github.com/DynamoRIO/dynamorio/commit/1d92b08e0a27ef089154b4cb54bd1c2...

Final commit log: 
---------------
i#1114 JIT optimization: remove client dependencies

Removes dependencies on the client interface
that were mistakenly used in the red-black tree
unit test. Using internal functions instead.

Review-URL: https://codereview.appspot.com/282070043
---------------