Issue 28162: Opensocial Templates minor spec updates

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 28162: Opensocial Templates minor spec updates

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by levik

Modified:
9 years, 4 months ago

Reviewers:
awiner

Base URL:
http://opensocial-resources.googlecode.com/svn/spec/

Visibility:
Public.

Description

- added spec for <os:Html> - added seciton on special-case attribute removal - removed qualification for blanking out ${Cur} for custom tags

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed extra "XML" #

Patch Set 3 : Changed wording to make special-cased attributes examples rather than exhaustive list #

Patch Set 4 : "falsey" -> "false-like" #

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -2 lines)			Patch
	M	draft/OpenSocial-Templating.xml	View	1 2 3	4 chunks	+57 lines, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

awiner

15 years ago (2009-04-01 16:01:21 UTC) #1

+1 on the whole, but some content tweaks suggested.

http://codereview.appspot.com/28162/diff/1/2
File draft/OpenSocial-Templating.xml (right):

http://codereview.appspot.com/28162/diff/1/2#newcode134
Line 134: Expressions are honored XML inside text nodes and attribute values.
They will
honored XML?

http://codereview.appspot.com/28162/diff/1/2#newcode195
Line 195: <t>@disabled attribute of the &lt;input&gt;, &lt;button&gt;,
&lt;select&gt; and &lt;textarea&gt; tags</t>
missing attributes:
 
readonly, on input and textarea
ismap on input and img
disabled on optgroup
multiple on select
defer on script
compact on DIR, DL, MENU, OL, UL,
etc....  it's actually a long list.

Recommend stating this applies to all boolean HTML attributes and not trying to
copy the full list.

http://codereview.appspot.com/28162/diff/1/2#newcode690
Line 690: be sanitized away. Containers should allow minimal functionality such
as making text bold or changing its color,
+1 to allowing sanitization.  Glad to see this in there.

Expand All Messages | Collapse All Messages