Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7465)

Issue 281490043: Add a new section 'Corpus Based Fuzzing' in fuzzer.dox

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by zhaoqin
Modified:
8 years, 3 months ago
Reviewers:
bruening
CC:
drmemory-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- Add a new section 'Corpus Based Fuzzing' in fuzzer.dox - add ToC in fuzzer.dox - add a new section 'Corpus Based Fuzzing' in fuzzer.dox - add reference link form drfuzz.dox to fuzzer.dox ---------------

Patch Set 1 #

Patch Set 2 : update commit msg #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M drfuzz/drfuzz.dox View 1 chunk +4 lines, -2 lines 2 comments Download
M drmemory/docs/fuzzer.dox View 2 chunks +18 lines, -0 lines 6 comments Download

Messages

Total messages: 5
zhaoqin
8 years, 3 months ago (2016-01-21 23:01:08 UTC) #1
bruening
On 2016/01/21 23:01:08, zhaoqin wrote: > - add reference link form drfuzz.dox to fuzzer.dox typo
8 years, 3 months ago (2016-01-22 06:24:26 UTC) #2
zhaoqin
Commit log for latest patchset: --------------- Add a new section 'Corpus Based Fuzzing' in fuzzer.dox ...
8 years, 3 months ago (2016-01-22 15:27:10 UTC) #3
bruening
Several comments but shouldn't need another round so LGTM https://codereview.appspot.com/281490043/diff/20001/drfuzz/drfuzz.dox File drfuzz/drfuzz.dox (right): https://codereview.appspot.com/281490043/diff/20001/drfuzz/drfuzz.dox#newcode39 drfuzz/drfuzz.dox:39: ...
8 years, 3 months ago (2016-01-22 17:42:24 UTC) #4
zhaoqin
8 years, 3 months ago (2016-01-22 20:35:02 UTC) #5
https://codereview.appspot.com/281490043/diff/20001/drfuzz/drfuzz.dox
File drfuzz/drfuzz.dox (right):

https://codereview.appspot.com/281490043/diff/20001/drfuzz/drfuzz.dox#newcode39
drfuzz/drfuzz.dox:39: Dr. Fuzz is part of the Dr. Memory Framework. And it is
used to
On 2016/01/22 17:42:24, bruening wrote:
> Starting a sentence with "And" is considered bad form.  Something like "Dr.
Fuzz
> is used ..." would be better.

done.
Just three Dr. fuzz start 3 consecutive sentences does not sounds good.

https://codereview.appspot.com/281490043/diff/20001/drmemory/docs/fuzzer.dox
File drmemory/docs/fuzzer.dox (right):

https://codereview.appspot.com/281490043/diff/20001/drmemory/docs/fuzzer.dox#...
drmemory/docs/fuzzer.dox:163: \section sec_corpus Corpus Based Fuzzing
On 2016/01/22 17:42:24, bruening wrote:
> Corpus-Based
> 
> update commit msg too

Done.

https://codereview.appspot.com/281490043/diff/20001/drmemory/docs/fuzzer.dox#...
drmemory/docs/fuzzer.dox:165: Dr. Memory supports corpus based fuzzing through
the following options:
On 2016/01/22 17:42:24, bruening wrote:
> This needs more explanation and background info: explain that each input is
> stored by itself in a separate file in a specified directory, and that there
> should be nothing else in the directory.

Done.

https://codereview.appspot.com/281490043/diff/20001/drmemory/docs/fuzzer.dox#...
drmemory/docs/fuzzer.dox:165: Dr. Memory supports corpus based fuzzing through
the following options:
On 2016/01/22 17:42:24, bruening wrote:
> This needs more explanation and background info: explain that each input is
> stored by itself in a separate file in a specified directory, and that there
> should be nothing else in the directory.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b