Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4020)

Issue 281080043: i#1114 JIT optimization: fragment tree API

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by Byron
Modified:
8 years, 4 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1114 JIT optimization: fragment tree API Defines structs for the JIT fragment tree, along with the API for general fragment accounting. Also adds a stub for a tree unit test. ---------------

Patch Set 1 #

Total comments: 2

Patch Set 2 : updating from my local #

Patch Set 3 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -5 lines) Patch
M core/jit_opt.h View 1 chunk +1 line, -1 line 0 comments Download
M core/jit_opt.c View 1 2 2 chunks +126 lines, -4 lines 0 comments Download
M core/unit_tests.c View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Byron
8 years, 4 months ago (2015-12-17 13:19:17 UTC) #1
Byron
The fragment tree is complete in my local branch, including a randomized unit test that ...
8 years, 4 months ago (2015-12-17 13:26:27 UTC) #2
Byron
Commit log for latest patchset: --------------- i#1114 JIT optimization: fragment tree API Defines structs for ...
8 years, 4 months ago (2015-12-19 06:22:12 UTC) #3
Byron
I'm removing the lookup_for_insert() and insert_at() functions because there's nothing to gain--maintenance of the subtree ...
8 years, 4 months ago (2015-12-19 06:25:07 UTC) #4
bruening
LGTM
8 years, 4 months ago (2015-12-20 15:48:09 UTC) #5
Byron
8 years, 4 months ago (2015-12-20 18:18:47 UTC) #6
Committed as
https://github.com/DynamoRIO/dynamorio/commit/747d74a7569f44861c04d1051cdb869...

Final commit log: 
---------------
i#1114 JIT optimization: fragment tree API

Defines structs for the JIT fragment tree, along
with the API for general fragment accounting. Also
adds a stub for a tree unit test.

Review-URL: https://codereview.appspot.com/281080043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b