Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7255)

Issue 280950043: i#1114 JIT optimization: add option and annotations

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by Byron
Modified:
8 years, 4 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1114 JIT optimization: add option and annotations Adds option -opt_jit to enable the JIT optimization. Adds the annotations for identifying JIT code, and registers them in an otherwise empty stub of the new jit_opt core module. ---------------

Patch Set 1 #

Total comments: 8

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
M core/CMakeLists.txt View 1 chunk +1 line, -0 lines 0 comments Download
M core/dynamo.c View 3 chunks +3 lines, -0 lines 0 comments Download
A core/jit_opt.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
A core/jit_opt.c View 1 1 chunk +43 lines, -0 lines 0 comments Download
M core/lib/dr_annotations.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M core/lib/dr_annotations.c View 1 chunk +6 lines, -0 lines 0 comments Download
M core/optionsx.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Byron
8 years, 4 months ago (2015-12-10 09:32:25 UTC) #1
bruening
LGTM w/ comments https://codereview.appspot.com/280950043/diff/1/core/dynamo.c File core/dynamo.c (right): https://codereview.appspot.com/280950043/diff/1/core/dynamo.c#newcode967 core/dynamo.c:967: jitopt_exit(); There is both a fast ...
8 years, 4 months ago (2015-12-11 20:46:41 UTC) #2
Byron
Committed as https://github.com/DynamoRIO/dynamorio/commit/a492fa3e19c9e27a5e3b109e3c98efa3fda4817f Final commit log: --------------- i#1114 JIT optimization: add option and annotations Adds ...
8 years, 4 months ago (2015-12-11 22:43:13 UTC) #3
Byron
8 years, 4 months ago (2015-12-11 22:44:54 UTC) #4
https://codereview.appspot.com/280950043/diff/1/core/dynamo.c
File core/dynamo.c (right):

https://codereview.appspot.com/280950043/diff/1/core/dynamo.c#newcode967
core/dynamo.c:967: jitopt_exit();
On 2015/12/11 20:46:41, bruening wrote:
> There is both a fast exit and a slow exit: you only added to the slow exit, so
I
> assume there's nothing to be done in release build.

Acknowledged.

https://codereview.appspot.com/280950043/diff/1/core/jit_opt.h
File core/jit_opt.h (right):

https://codereview.appspot.com/280950043/diff/1/core/jit_opt.h#newcode4
core/jit_opt.h:4: #ifdef ANNOTATIONS /* around whole file */
On 2015/12/11 20:46:41, bruening wrote:
> What about the auto-infer scheme?  It doesn't need annotations, and won't its
> code live here?

Done.

https://codereview.appspot.com/280950043/diff/1/core/lib/dr_annotations.h
File core/lib/dr_annotations.h (right):

https://codereview.appspot.com/280950043/diff/1/core/lib/dr_annotations.h#new...
core/lib/dr_annotations.h:57: #define DYNAMORIO_ANNOTATE_MANAGE_CODE_AREA(start,
size) \
On 2015/12/11 20:46:41, bruening wrote:
> Why are they "DR_DECLARE_ANNOTATION" above but different here?

Done.

https://codereview.appspot.com/280950043/diff/1/core/optionsx.h
File core/optionsx.h (right):

https://codereview.appspot.com/280950043/diff/1/core/optionsx.h#newcode316
core/optionsx.h:316: OPTION_DEFAULT(bool, opt_jit, false,
On 2015/12/11 20:46:41, bruening wrote:
> How about an XXX i#... for turning this to true by default

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b