i#1734 drfuzz: add -fuzz_call_convention for specify calling convention

Commit log for first patchset:
---------------
i#1734 drfuzz: add -fuzz_call_convention for specify calling convention

- add -fuzz_call_convention
- update fuzzer.dox for -fuzz_call_convention
- update fuzz_init to handle -fuzz_call_convention
- update fuzz_buffer.cpp test to test -fuzz_call_convention
---------------

[bruening, 2015-12-03 16:00:17]

On 2015/12/03 05:32:50, zhaoqin wrote:
> i#1734 drfuzz: add -fuzz_call_convention for specify calling convention

Please correct the grammar.

[zhaoqin, 2015-12-03 18:25:25]

Commit log for latest patchset:
---------------
i#1734 drfuzz: add -fuzz_call_convention for target function calling convention

- add -fuzz_call_convention in optionsx.h
- add description about using -fuzz_call_convention in fuzzer.dox
- update fuzz_init in fuzzer.c to handle -fuzz_call_convention
- update fuzz/CMakeLists.txt to test -fuzz_call_convention with fuzz_buffer.cpp

Review-URL: https://codereview.appspot.com/280200044
---------------

[bruening, 2015-12-04 17:58:10]

Several issues with the docs but otherwise LGTM

https://codereview.appspot.com/280200044/diff/20001/drmemory/docs/fuzzer.dox
File drmemory/docs/fuzzer.dox (right):

https://codereview.appspot.com/280200044/diff/20001/drmemory/docs/fuzzer.dox#...
drmemory/docs/fuzzer.dox:84: different calling convention, \p thiscall for C++
non-static member
I don't understand this comma connection.  I assume you mean "convention for
fuzz target functions, such as "

https://codereview.appspot.com/280200044/diff/20001/drmemory/docs/fuzzer.dox#...
drmemory/docs/fuzzer.dox:85: functions as fuzz target functions. It is also
possible to
and remove it from here b/c it's not part of the example, it's part of the
up-front idea

https://codereview.appspot.com/280200044/diff/20001/drmemory/docs/fuzzer.dox#...
drmemory/docs/fuzzer.dox:96: The calling convention \p 6 specifies \p thiscall
(as defined by the enum
This is confusing: does -fuzz_call_convention also take "6"?  But you implied it
takes a string "thiscall"?  Please give an example of using
-fuzz_call_convention.

https://codereview.appspot.com/280200044/diff/20001/drmemory/fuzzer.c
File drmemory/fuzzer.c (right):

https://codereview.appspot.com/280200044/diff/20001/drmemory/fuzzer.c#newcode274
drmemory/fuzzer.c:274: else if (strcmp(options.fuzz_call_convention, "thiscall")
== 0)
So it doesn't take numbers, it takes strings.  Please make that clear in the
.dox.

https://codereview.appspot.com/280200044/diff/20001/drmemory/optionsx.h
File drmemory/optionsx.h (right):

https://codereview.appspot.com/280200044/diff/20001/drmemory/optionsx.h#newco...
drmemory/optionsx.h:622: "The calling convention used by the fuzz target
function,"NL
bug: comma cannot connect two sentences

https://codereview.appspot.com/280200044/diff/20001/drmemory/optionsx.h#newco...
drmemory/optionsx.h:630: "The calling convention used by the fuzz target
function. It can be specified using one of the following
codes:<pre>&nbsp;&nbsp;&nbsp;&nbsp;<code>amd64    =
AMD64</code>\n&nbsp;&nbsp;&nbsp;&nbsp;<code>ms64     = Microsoft x64 (Visual
Studio)</code>\n&nbsp;&nbsp;&nbsp;&nbsp;<code>arm32    =
ARM32</code>\n&nbsp;&nbsp;&nbsp;&nbsp;<code>stdcall  = cdecl or
stdcall</code>\n&nbsp;&nbsp;&nbsp;&nbsp;<code>fastcall =
fastcall</code>\n&nbsp;&nbsp;&nbsp;&nbsp;<code>thiscall = thiscall</code></pre> 
If no calling convention is specified, the most common calling convention on the
platform is used.")
This is hard to read in here -- maybe it should be split up.

https://codereview.appspot.com/280200044/diff/20001/drmemory/optionsx.h#newco...
drmemory/optionsx.h:630: "The calling convention used by the fuzz target
function. It can be specified using one of the following
codes:<pre>&nbsp;&nbsp;&nbsp;&nbsp;<code>amd64    =
AMD64</code>\n&nbsp;&nbsp;&nbsp;&nbsp;<code>ms64     = Microsoft x64 (Visual
Studio)</code>\n&nbsp;&nbsp;&nbsp;&nbsp;<code>arm32    =
ARM32</code>\n&nbsp;&nbsp;&nbsp;&nbsp;<code>stdcall  = cdecl or
stdcall</code>\n&nbsp;&nbsp;&nbsp;&nbsp;<code>fastcall =
fastcall</code>\n&nbsp;&nbsp;&nbsp;&nbsp;<code>thiscall = thiscall</code></pre> 
If no calling convention is specified, the most common calling convention on the
platform is used.")
Please clarify "the most common": best to list what the default is for each
platform.

[zhaoqin, 2015-12-08 16:32:45]

Commit log for latest patchset:
---------------
i#1734 drfuzz: add -fuzz_call_convention for target function calling convention

- add -fuzz_call_convention in optionsx.h
- add description about using -fuzz_call_convention in fuzzer.dox
- update fuzz_init in fuzzer.c to handle -fuzz_call_convention
- update fuzz/CMakeLists.txt to test -fuzz_call_convention with fuzz_buffer.cpp

Review-URL: https://codereview.appspot.com/280200044
---------------

[zhaoqin, 2015-12-08 16:58:12]

Committed as
https://github.com/DynamoRIO/drmemory/commit/9f5abca7c788d07c39be8e46cdec3e8f...

Final commit log: 
---------------
i#1734 drfuzz: add -fuzz_call_convention for target function calling convention

- add -fuzz_call_convention in optionsx.h
- add description about using -fuzz_call_convention in fuzzer.dox
- update fuzz_init in fuzzer.c to handle -fuzz_call_convention
- update fuzz/CMakeLists.txt to test -fuzz_call_convention with fuzz_buffer.cpp

Review-URL: https://codereview.appspot.com/280200044
---------------