code review 2791042: support append, other builtins

support append, other builtins

[ajstarks, 2010-10-29 04:34:40]

Hello golang-dev@googlegroups.com,

I'd like you to review this change.

[peterGo, 2010-10-29 14:58:18]

http://codereview.appspot.com/2791042/diff/2001/misc/bbedit/Go.plist
File misc/bbedit/Go.plist (right):

http://codereview.appspot.com/2791042/diff/2001/misc/bbedit/Go.plist#newcode8
misc/bbedit/Go.plist:8: BBLMKeywordList = (
Why do you omit some predeclared identifiers e.g. complex, complex64,
complex128, and recover?
Predeclared identifiers,The Go Programming Language Specification.
http://golang.org/doc/go_spec.html#Predeclared_identifiers

[ajstarks, 2010-10-29 22:17:44]

Hello golang-dev@googlegroups.com, PeterGo (cc: golang-dev@googlegroups.com),

Please take another look.

[ajstarks, 2010-10-29 22:19:05]

updated 
On Oct 29, 2010, at 10:58 AM, go.peter.90@gmail.com wrote:

> 
> http://codereview.appspot.com/2791042/diff/2001/misc/bbedit/Go.plist
> File misc/bbedit/Go.plist (right):
> 
> http://codereview.appspot.com/2791042/diff/2001/misc/bbedit/Go.plist#newcode8
> misc/bbedit/Go.plist:8: BBLMKeywordList = (
> Why do you omit some predeclared identifiers e.g. complex, complex64,
> complex128, and recover?
> Predeclared identifiers,The Go Programming Language Specification.
> http://golang.org/doc/go_spec.html#Predeclared_identifiers
> 
> http://codereview.appspot.com/2791042/

[peterGo, 2010-10-29 22:51:59]

The first line of the CL description should indicate which package or component
is being changed. For example,

bbedit: support append, other builtins

LGTM

[adg, 2010-10-30 11:16:36]

LGTM.

Thanks.

On 30 October 2010 09:51,  <go.peter.90@gmail.com> wrote:
> The first line of the CL description should indicate which package or
> component is being changed. For example,
>
> bbedit: support append, other builtins
>
> LGTM
>
>
>
> http://codereview.appspot.com/2791042/
>

[adg, 2010-10-30 11:17:57]

*** Submitted as http://code.google.com/p/go/source/detail?r=f5d193e5b14a ***

misc/bbedit: support append, other builtins

R=golang-dev, PeterGo, adg
CC=golang-dev
http://codereview.appspot.com/2791042

Committer: Andrew Gerrand <adg@golang.org>