i#1734: Dr.Fuzz: add -fuzz_input_file option

Commit log for first patchset:
---------------
i#1734: Dr.Fuzz: add -fuzz_input_file option

- add -fuzz_input_file option to load data from file as fuzz input
- add fuzz_buffer.load_input test
- adjust fuzz_buffer.one-input test to avoid trailing space warning
- add section in fuzzer.dox talking about dump/load fuzz input
---------------

[zhaoqin, 2015-12-09 20:10:43]

Commit log for latest patchset:
---------------
i#1734: Dr.Fuzz: add -fuzz_input_file option

- add -fuzz_input_file option to load data from file as fuzz input
- add fuzz_buffer.load_input test
- adjust fuzz_buffer.one-input test to avoid trailing space warning
- add section in fuzzer.dox talking about dump/load fuzz input

Review-URL: https://codereview.appspot.com/278420043
---------------

[zhaoqin, 2015-12-09 20:48:07]

Commit log for latest patchset:
---------------
i#1734: Dr.Fuzz: add -fuzz_input_file option

- add -fuzz_input_file option to load data from file as fuzz input
- add fuzz_buffer.load_input test
- adjust fuzz_buffer.one-input test to avoid trailing space warning
- add section in fuzzer.dox talking about dump/load fuzz input

Review-URL: https://codereview.appspot.com/278420043
---------------

[zhaoqin, 2015-12-09 22:10:34]

Commit log for latest patchset:
---------------
i#1734: Dr.Fuzz: add -fuzz_input_file option

- add -fuzz_input_file option to load data from file as fuzz input
- add fuzz_buffer.load_input test
- adjust fuzz_buffer.one-input test to avoid trailing space warning
- add section in fuzzer.dox talking about dump/load fuzz input

Review-URL: https://codereview.appspot.com/278420043
---------------

[bruening, 2015-12-10 04:33:24]

LGTM w/ a bunch of comments

https://codereview.appspot.com/278420043/diff/60001/drmemory/docs/fuzzer.dox
File drmemory/docs/fuzzer.dox (right):

https://codereview.appspot.com/278420043/diff/60001/drmemory/docs/fuzzer.dox#...
drmemory/docs/fuzzer.dox:247: \section sec_dump_load Dump and Load Fuzz Input
Data
Dumping and Loading

https://codereview.appspot.com/278420043/diff/60001/drmemory/docs/fuzzer.dox#...
drmemory/docs/fuzzer.dox:251: for reproducing the error later with option \p
-fuzz_input_file.
the option

https://codereview.appspot.com/278420043/diff/60001/drmemory/fuzzer.c
File drmemory/fuzzer.c (right):

https://codereview.appspot.com/278420043/diff/60001/drmemory/fuzzer.c#newcode408
drmemory/fuzzer.c:408: ELOG(1, "Failed to open input file");
Please add at least the word "fuzz": this message is too generic to know what it
means

https://codereview.appspot.com/278420043/diff/60001/drmemory/fuzzer.c#newcode408
drmemory/fuzzer.c:408: ELOG(1, "Failed to open input file");
Why not use FUZZ_ERROR instead?

https://codereview.appspot.com/278420043/diff/60001/drmemory/fuzzer.c#newcode414
drmemory/fuzzer.c:414: ELOG(1, "Failed to read input file");
Ditto

https://codereview.appspot.com/278420043/diff/60001/drmemory/fuzzer.c#newcode417
drmemory/fuzzer.c:417: /* FIXME i#1734: we may need update shadow state for
loaded data */
to

https://codereview.appspot.com/278420043/diff/60001/drmemory/optionsx.h
File drmemory/optionsx.h (right):

https://codereview.appspot.com/278420043/diff/60001/drmemory/optionsx.h#newco...
drmemory/optionsx.h:622: "The number of times (100 by default) to repeat
executing the target function.",
Please remove the "(100 by default)" as it's already in the output!

Please do the same above -- I see 3 other drfuzz options that have this
redundant string.

https://codereview.appspot.com/278420043/diff/60001/drmemory/optionsx.h#newco...
drmemory/optionsx.h:623: "The number of times (100 by default) to repeat
executing the target function. "
Ditto

https://codereview.appspot.com/278420043/diff/60001/drmemory/optionsx.h#newco...
drmemory/optionsx.h:624: "0 for no repeat and no mutation, and -1 for repeat
until the mutator is exhausted.")
?  You're missing "Use " at the start.

https://codereview.appspot.com/278420043/diff/60001/drmemory/optionsx.h#newco...
drmemory/optionsx.h:624: "0 for no repeat and no mutation, and -1 for repeat
until the mutator is exhausted.")
s/for repeat/to repeat/

https://codereview.appspot.com/278420043/diff/60001/drmemory/optionsx.h#newco...
drmemory/optionsx.h:655: "Load data from specified file as fuzz input. It can be
used with '-fuzz_num_iters 0' to reproduce an error from the input generated by
'-fuzz_dump_on_error'.",
The 1st string is supposed to be a short description, half of a line if
possible.  I would say, remove the 2nd sentence entirely.  If it's important to
keep, put it on a 2nd line (requires indentation) to avoid scrolling way off the
end.

https://codereview.appspot.com/278420043/diff/60001/drmemory/optionsx.h#newco...
drmemory/optionsx.h:668: "        the target function (use 0 for no repeat and
no mutation). The alias"NL
So no -1 mention?

https://codereview.appspot.com/278420043/diff/60001/tests/fuzz/CMakeLists.txt
File tests/fuzz/CMakeLists.txt (right):

https://codereview.appspot.com/278420043/diff/60001/tests/fuzz/CMakeLists.txt...
tests/fuzz/CMakeLists.txt:72: DESTINATION "${PROJECT_BINARY_DIR}/tests/fuzz/")
If this is a copy with no changes, why do we need it at all?  Why can't we just
point at the original?

[zhaoqin, 2015-12-10 18:15:56]

Commit log for latest patchset:
---------------
i#1734: Dr.Fuzz: add -fuzz_input_file option

- add -fuzz_input_file option to load data from file as fuzz input
- add fuzz_buffer.load_input test
- adjust fuzz_buffer.one-input test to avoid trailing space warning
- add section in fuzzer.dox talking about dump/load fuzz input

Review-URL: https://codereview.appspot.com/278420043
---------------

[zhaoqin, 2015-12-10 19:39:04]

Committed as
https://github.com/DynamoRIO/drmemory/commit/04ef59efd8783ac06dd7a3211205bad6...

Final commit log: 
---------------
i#1734: Dr.Fuzz: add -fuzz_input_file option

- add -fuzz_input_file option to load data from file as fuzz input
- add fuzz_buffer.load_input test
- adjust fuzz_buffer.one-input test to avoid trailing space warning
- add section in fuzzer.dox talking about dump/load fuzz input

Review-URL: https://codereview.appspot.com/278420043
---------------