Issue 277860043: make supportNonIntegerFret a context-property

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 277860043: make supportNonIntegerFret a context-property (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 6 months ago by thomasmorley651

Modified:
8 years, 4 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

make supportNonIntegerFret a context-property restores the arguments of determine-frets (changed with issue 4643) to the previous state, changes the code of determine-frets to rely on the newly created supportNonIntegerFret-context-property

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -14 lines)			Patch
M	Documentation/changes.tely	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Documentation/notation/fretted-strings.itely	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	input/regression/tablature-micro-tone.ly	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	ly/engraver-init.ly	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	scm/define-context-properties.scm	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	scm/translation-functions.scm	View	4 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

thomasmorley651

8 years, 6 months ago (2015-11-08 22:58:20 UTC) #1

please review

this is a follow up to issue 4643
https://sourceforge.net/p/testlilyissues/issues/4643/
see discussion:
https://codereview.appspot.com/272320043/

Expand All Messages | Collapse All Messages