Bug 1229899 - Remove SSL_ENABLE_SSL2 and SSL_V2_COMPATIBLE_HELLO

Bug 1229899 - Remove SSL_ENABLE_SSL2 and SSL_V2_COMPATIBLE_HELLO

[mt, 2015-12-03 07:02:52]

That pk11 test is awful.  If it isn't being run, then it might be a good time to
kill it.

https://codereview.appspot.com/277190043/diff/1/lib/ssl/ssl.h
File lib/ssl/ssl.h (left):

https://codereview.appspot.com/277190043/diff/1/lib/ssl/ssl.h#oldcode97
lib/ssl/ssl.h:97: /* (off by default) */
I think that you will need to leave these in.

https://codereview.appspot.com/277190043/diff/1/tests/pkcs11/netscape/suites/...
File tests/pkcs11/netscape/suites/security/ssl/sslc.c (left):

https://codereview.appspot.com/277190043/diff/1/tests/pkcs11/netscape/suites/...
tests/pkcs11/netscape/suites/security/ssl/sslc.c:152: }
Remove this too.

https://codereview.appspot.com/277190043/diff/1/tests/pkcs11/netscape/suites/...
File tests/pkcs11/netscape/suites/security/ssl/sslt.c (left):

https://codereview.appspot.com/277190043/diff/1/tests/pkcs11/netscape/suites/...
tests/pkcs11/netscape/suites/security/ssl/sslt.c:461: )
Hmm, I think perhaps you need to work out if this code is run.  It's awful.

Since you are removing all the version checking, I think that you need to also
remove some bits from the repetition count.

https://codereview.appspot.com/277190043/diff/1/tests/pkcs11/netscape/suites/...
File tests/pkcs11/netscape/suites/security/ssl/sslt.h (left):

https://codereview.appspot.com/277190043/diff/1/tests/pkcs11/netscape/suites/...
tests/pkcs11/netscape/suites/security/ssl/sslt.h:149: #define REP_SSLVersion3   
       SSLVersion3[testId/2/1/2/2%2]
I think that you can get rid of the REP_SSLVersion3 part as well.  I would rely
on the defaults.

Also, I think that since this has removed one (I suggest two) bits from the
repetition count, the later defines could have two "/2" divides removed.  I
don't know where the final count is kept, but that could be divided by 4 as
well.

[ttaubert, 2015-12-03 09:29:19]

On 2015/12/03 07:02:52, mt wrote:
> That pk11 test is awful.  If it isn't being run, then it might be a good time
to
> kill it.

Agreed. I removed everything in tests/pkcs11/ as I couldn't find any evidence
that these tests are run or even built by default.

> https://codereview.appspot.com/277190043/diff/1/lib/ssl/ssl.h#oldcode97
> lib/ssl/ssl.h:97: /* (off by default) */
> I think that you will need to leave these in.

Right, I put them back.

[mt, 2015-12-05 10:19:27]

LGTM