Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(107)

Issue 277040044: Bug 917571 - Add ChaCha20+Poly1305 cipher (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by ttaubert
Modified:
5 years, 2 months ago
Reviewers:
mt, wtc, wtc1
Visibility:
Public.

Description

Bug 917571 - Add ChaCha20+Poly1305 cipher

Patch Set 1 #

Total comments: 12

Patch Set 2 : Addressed all review comments for patch set #1 #

Patch Set 3 : s/ulIvLen/ulNonceLen for CK_NSS_AEAD_PARAMS #

Total comments: 52

Patch Set 4 : Addressed wtc's review comments #

Total comments: 7

Patch Set 5 : Final version #

Total comments: 1

Patch Set 6 : Final final version #

Patch Set 7 : Rebased and reworked (G)CC_VERSION detection and handling #

Total comments: 8

Patch Set 8 : Use CC_IS_GCC instead of checking that CC_NAME==gcc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2275 lines, -28 lines) Patch
M circle.yml View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M cmd/bltest/blapitest.c View 1 2 3 4 14 chunks +157 lines, -17 lines 0 comments Download
A cmd/bltest/tests/chacha20_poly1305/aad0 View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A cmd/bltest/tests/chacha20_poly1305/aad1 View Binary file 0 comments Download
A cmd/bltest/tests/chacha20_poly1305/ciphertext0 View 1 chunk +1 line, -0 lines 0 comments Download
A cmd/bltest/tests/chacha20_poly1305/ciphertext1 View 1 chunk +1 line, -0 lines 0 comments Download
A cmd/bltest/tests/chacha20_poly1305/iv0 View Binary file 0 comments Download
A cmd/bltest/tests/chacha20_poly1305/iv1 View Binary file 0 comments Download
A cmd/bltest/tests/chacha20_poly1305/key0 View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A cmd/bltest/tests/chacha20_poly1305/key1 View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A + cmd/bltest/tests/chacha20_poly1305/numtests View 0 chunks +-1 lines, --1 lines 0 comments Download
A cmd/bltest/tests/chacha20_poly1305/plaintext0 View 1 chunk +1 line, -0 lines 0 comments Download
A cmd/bltest/tests/chacha20_poly1305/plaintext1 View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M coreconf/Werror.mk View 1 2 3 4 5 6 7 3 chunks +17 lines, -8 lines 0 comments Download
M external_tests/pk11_gtest/manifest.mn View 1 chunk +1 line, -0 lines 0 comments Download
A external_tests/pk11_gtest/pk11_chacha20poly1305_unittest.cc View 1 2 1 chunk +277 lines, -0 lines 0 comments Download
M lib/freebl/Makefile View 1 2 3 4 5 6 7 1 chunk +25 lines, -0 lines 0 comments Download
M lib/freebl/blapi.h View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
M lib/freebl/blapit.h View 2 chunks +2 lines, -0 lines 0 comments Download
A lib/freebl/chacha20/chacha20.h View 1 chunk +20 lines, -0 lines 0 comments Download
A lib/freebl/chacha20/chacha20.c View 1 2 3 1 chunk +111 lines, -0 lines 0 comments Download
A lib/freebl/chacha20/chacha20_vec.c View 1 2 3 1 chunk +278 lines, -0 lines 0 comments Download
A lib/freebl/chacha20poly1305.h View 1 chunk +15 lines, -0 lines 0 comments Download
A lib/freebl/chacha20poly1305.c View 1 2 3 1 chunk +174 lines, -0 lines 0 comments Download
M lib/freebl/ldvector.c View 1 chunk +9 lines, -1 line 0 comments Download
M lib/freebl/loader.h View 1 2 3 2 chunks +28 lines, -1 line 0 comments Download
M lib/freebl/loader.c View 1 2 3 4 5 1 chunk +56 lines, -0 lines 0 comments Download
M lib/freebl/manifest.mn View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
A lib/freebl/poly1305/poly1305.h View 1 chunk +28 lines, -0 lines 0 comments Download
A lib/freebl/poly1305/poly1305.c View 1 2 3 1 chunk +254 lines, -0 lines 0 comments Download
A lib/freebl/poly1305/poly1305-donna-x64-sse2-incremental-source.c View 1 2 3 1 chunk +623 lines, -0 lines 0 comments Download
M lib/pk11wrap/pk11mech.c View 3 chunks +7 lines, -0 lines 0 comments Download
M lib/softoken/pkcs11.c View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/softoken/pkcs11c.c View 1 2 3 4 5 4 chunks +124 lines, -0 lines 0 comments Download
M lib/softoken/pkcs11i.h View 1 2 3 3 chunks +12 lines, -0 lines 0 comments Download
M lib/util/pkcs11n.h View 1 2 3 chunks +13 lines, -0 lines 0 comments Download
M tests/cipher/cipher.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18
mt
LGTM https://codereview.appspot.com/277040044/diff/1/cmd/bltest/blapitest.c File cmd/bltest/blapitest.c (right): https://codereview.appspot.com/277040044/diff/1/cmd/bltest/blapitest.c#newcode848 cmd/bltest/blapitest.c:848: case bltestCHACHA20: why isn't AES-GCM an aead cipher? ...
5 years, 4 months ago (2015-12-05 09:25:22 UTC) #1
ttaubert
On 2015/12/05 09:25:22, mt wrote: > https://codereview.appspot.com/277040044/diff/1/cmd/bltest/blapitest.c#newcode848 > cmd/bltest/blapitest.c:848: case bltestCHACHA20: > why isn't AES-GCM ...
5 years, 2 months ago (2016-01-16 13:52:56 UTC) #2
wtc1
Review comments on patch set 3: cmd/bltest/blapitest.c I only had time to review cmd/bltest/blapitest.c today. ...
5 years, 2 months ago (2016-01-31 03:12:02 UTC) #3
wtc1
Patch set 3 LGTM. I didn't review pk11_gtest. Tim: thank you for updating the Chromium ...
5 years, 2 months ago (2016-01-31 20:00:27 UTC) #4
mt
https://codereview.appspot.com/277040044/diff/40001/coreconf/Werror.mk File coreconf/Werror.mk (right): https://codereview.appspot.com/277040044/diff/40001/coreconf/Werror.mk#newcode15 coreconf/Werror.mk:15: export CC_VERSION On 2016/01/31 20:00:25, wtc1 wrote: > > ...
5 years, 2 months ago (2016-01-31 23:40:08 UTC) #5
ttaubert
On 2016/01/31 20:00:27, wtc1 wrote: > Tim: thank you for updating the Chromium patch to ...
5 years, 2 months ago (2016-02-01 15:49:30 UTC) #6
wtc1
https://codereview.appspot.com/277040044/diff/40001/coreconf/Werror.mk File coreconf/Werror.mk (right): https://codereview.appspot.com/277040044/diff/40001/coreconf/Werror.mk#newcode15 coreconf/Werror.mk:15: export CC_VERSION On 2016/01/31 23:40:08, mt wrote: > > ...
5 years, 2 months ago (2016-02-01 17:25:18 UTC) #7
wtc1
Patch set 4 LGTM. Thanks! I reviewed the diffs between patch sets 3 and 4 ...
5 years, 2 months ago (2016-02-01 17:52:31 UTC) #8
ttaubert
On 2016/02/01 17:25:18, wtc1 wrote: > Thanks for the explanation. I am surprised that using ...
5 years, 2 months ago (2016-02-01 18:17:04 UTC) #9
ttaubert
https://codereview.appspot.com/277040044/diff/60001/cmd/bltest/blapitest.c File cmd/bltest/blapitest.c (right): https://codereview.appspot.com/277040044/diff/60001/cmd/bltest/blapitest.c#newcode614 cmd/bltest/blapitest.c:614: unsigned int inputLen); On 2016/02/01 17:52:30, wtc1 wrote: > ...
5 years, 2 months ago (2016-02-01 18:21:13 UTC) #10
wtc1
Patch set 5 LGTM. https://codereview.appspot.com/277040044/diff/80001/coreconf/Werror.mk File coreconf/Werror.mk (right): https://codereview.appspot.com/277040044/diff/80001/coreconf/Werror.mk#newcode11 coreconf/Werror.mk:11: # recursing. This was added ...
5 years, 2 months ago (2016-02-01 18:48:10 UTC) #11
ttaubert
On 2016/02/01 18:48:10, wtc1 wrote: > https://codereview.appspot.com/277040044/diff/80001/coreconf/Werror.mk#newcode11 > coreconf/Werror.mk:11: # recursing. This was added to ...
5 years, 2 months ago (2016-02-01 18:52:14 UTC) #12
mt
A few suggestions for improvements. https://codereview.appspot.com/277040044/diff/100001/coreconf/Werror.mk File coreconf/Werror.mk (right): https://codereview.appspot.com/277040044/diff/100001/coreconf/Werror.mk#newcode25 coreconf/Werror.mk:25: ifeq ($(CC_NAME),gcc) The problem ...
5 years, 2 months ago (2016-02-07 21:47:33 UTC) #13
mt
https://codereview.appspot.com/277040044/diff/100001/coreconf/Werror.mk File coreconf/Werror.mk (right): https://codereview.appspot.com/277040044/diff/100001/coreconf/Werror.mk#newcode25 coreconf/Werror.mk:25: ifeq ($(CC_NAME),gcc) On 2016/02/07 21:47:33, mt wrote: > The ...
5 years, 2 months ago (2016-02-08 02:48:20 UTC) #14
ttaubert
https://codereview.appspot.com/277040044/diff/100001/coreconf/Werror.mk File coreconf/Werror.mk (right): https://codereview.appspot.com/277040044/diff/100001/coreconf/Werror.mk#newcode25 coreconf/Werror.mk:25: ifeq ($(CC_NAME),gcc) On 2016/02/07 21:47:33, mt wrote: > The ...
5 years, 2 months ago (2016-02-08 14:51:17 UTC) #15
ttaubert
The latest patch set uses CC_IS_GCC to cover those versions that report a name of ...
5 years, 2 months ago (2016-02-08 14:53:22 UTC) #16
ttaubert
I'll wait for (or work on if needed) a final "LGTM" for the Makefile changes ...
5 years, 2 months ago (2016-02-08 19:00:38 UTC) #17
mt
5 years, 2 months ago (2016-02-08 21:37:53 UTC) #18
Patch set 7 LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b