Issue 276660043: i#1839 mcontext clobbered by dr_set_mcontext: avoid clobber

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 276660043: i#1839 mcontext clobbered by dr_set_mcontext: avoid clobber

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 3 months ago by zhaoqin

Modified:
8 years, 3 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1839 mcontext clobbered by dr_set_mcontext: avoid clobber - update dr_set_mcontext to avoid input mcontext to be clobbered Fixes #1839 ---------------

Patch Set 1 #

Patch Set 2 : fixed a compiler warning #

Patch Set 3 : Committed #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	core/lib/instrument.c	View	1 2	2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

zhaoqin

Commit log for latest patchset: --------------- i#1839 mcontext clobbered by dr_set_mcontext: avoid clobber - update ...

8 years, 3 months ago (2016-01-05 02:47:49 UTC) #2

bruening

> i#1839 mcontext clobbered by dr_set_mcontext: avoid clobber Generally, for issues fixed by a single ...

8 years, 3 months ago (2016-01-05 03:20:58 UTC) #3

zhaoqin

8 years, 3 months ago (2016-01-05 16:58:13 UTC) #4

Committed as
https://github.com/DynamoRIO/dynamorio/commit/a1de3d8df5c25b12b2383119e94a022...

Final commit log: 
---------------
i#1839: fix mcontext clobbered by dr_set_mcontext

Fixes a bug in dr_set_mcontext to avoid clobbering the input mcontext

Fixes #1839

Review-URL: https://codereview.appspot.com/276660043
---------------

Expand All Messages | Collapse All Messages