Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4671)

Issue 276070043: Switch to full chart API Add workaround required to used typed JS interop in 1.13 It could be cool …

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by jacobr
Modified:
8 years, 4 months ago
Reviewers:
kevmoo (at google)
CC:
sra_google.com, sigmund
Base URL:
git@github.com:google/chartjs.dart.git@master
Visibility:
Public.

Description

Switch to full chart API Add workaround required to used typed JS interop in 1.13 It could be cool to show more of the API in the sample now that there is a pretty full definition of it. BUG=

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+519 lines, -105 lines) Patch
M README.md View 1 chunk +1 line, -1 line 0 comments Download
M example/example.dart View 4 chunks +15 lines, -6 lines 0 comments Download
A lib/chart.dart View 1 chunk +502 lines, -0 lines 0 comments Download
D lib/chartjs.dart View 1 chunk +0 lines, -10 lines 0 comments Download
D lib/src/chart.dart View 1 1 chunk +0 lines, -18 lines 0 comments Download
D lib/src/data.dart View 1 1 chunk +0 lines, -18 lines 0 comments Download
D lib/src/data_set.dart View 1 1 chunk +0 lines, -34 lines 0 comments Download
D lib/src/options.dart View 1 1 chunk +0 lines, -18 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
jacobr
Kevin, if this looks good please git cl patch and commit. This is the autogenerated ...
8 years, 5 months ago (2015-11-18 07:23:43 UTC) #1
kevmoo (at google)
8 years, 4 months ago (2015-12-17 18:30:20 UTC) #2
I repackaged this w/ the recent fixes - https://github.com/google/chartjs.dart/

Cool!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b