Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(65)

Issue 27560044: Improve bundle logging and documentation.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by frankban
Modified:
5 years, 10 months ago
Reviewers:
mp+195824, rharding
Visibility:
Public.

Description

Improve bundle logging and documentation. Added bundle debugging instructions to the HACKING file. Improved bundle logging and error handling: empty exceptions arriving from juju-deployer are not left empty. https://code.launchpad.net/~frankban/charms/precise/juju-gui/improve-docs-logs/+merge/195824 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Improve bundle logging and documentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -5 lines) Patch
M HACKING.md View 1 chunk +36 lines, -0 lines 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M server/guiserver/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M server/guiserver/bundles/base.py View 1 chunk +5 lines, -2 lines 0 comments Download
M server/guiserver/bundles/utils.py View 4 chunks +23 lines, -0 lines 0 comments Download
M server/guiserver/bundles/views.py View 6 chunks +10 lines, -0 lines 0 comments Download
M server/guiserver/tests/bundles/test_base.py View 2 chunks +2 lines, -1 line 0 comments Download
M server/guiserver/tests/bundles/test_utils.py View 4 chunks +41 lines, -1 line 0 comments Download
M server/guiserver/tests/bundles/test_views.py View 5 chunks +60 lines, -0 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
5 years, 10 months ago (2013-11-19 16:53:14 UTC) #1
rharding
LGTM, thanks for helping with those error messages. https://codereview.appspot.com/27560044/diff/1/HACKING.md File HACKING.md (right): https://codereview.appspot.com/27560044/diff/1/HACKING.md#newcode229 HACKING.md:229: status ...
5 years, 10 months ago (2013-11-19 17:15:23 UTC) #2
frankban
*** Submitted: Improve bundle logging and documentation. Added bundle debugging instructions to the HACKING file. ...
5 years, 10 months ago (2013-11-19 17:26:47 UTC) #3
frankban
5 years, 10 months ago (2013-11-19 17:27:59 UTC) #4
Thank you!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b