Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(490)

Issue 275560043: Bug1227624-Protection

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by franziskus
Modified:
6 years, 8 months ago
Reviewers:
wtc1
Visibility:
Public.

Description

Bug1227624-Protection

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -56 lines) Patch
M lib/certdb/alg1485.c View 1 2 chunks +36 lines, -32 lines 2 comments Download
M lib/certdb/genname.c View 1 chunk +28 lines, -24 lines 1 comment Download

Messages

Total messages: 5
wtc1
Review comments on patch set 1: https://codereview.appspot.com/275560043/diff/1/lib/certdb/alg1485.c File lib/certdb/alg1485.c (right): https://codereview.appspot.com/275560043/diff/1/lib/certdb/alg1485.c#newcode37 lib/certdb/alg1485.c:37: SEC_ASN1_DS}, The original ...
6 years, 8 months ago (2015-11-25 19:09:22 UTC) #1
franziskus
On 2015/11/25 19:09:22, wtc1 wrote: > Review comments on patch set 1: > > https://codereview.appspot.com/275560043/diff/1/lib/certdb/alg1485.c ...
6 years, 8 months ago (2015-11-30 16:49:23 UTC) #2
wtc1
Patch set 2 LGTM. https://codereview.appspot.com/275560043/diff/20001/lib/certdb/alg1485.c File lib/certdb/alg1485.c (right): https://codereview.appspot.com/275560043/diff/20001/lib/certdb/alg1485.c#newcode128 lib/certdb/alg1485.c:128: ((c) == '<') || ((c) ...
6 years, 8 months ago (2015-11-30 23:20:21 UTC) #3
franziskus
On 2015/11/30 23:20:21, wtc1 wrote: > Patch set 2 LGTM. > > https://codereview.appspot.com/275560043/diff/20001/lib/certdb/alg1485.c > File ...
6 years, 8 months ago (2015-12-01 14:13:32 UTC) #4
wtc1
6 years, 8 months ago (2015-12-01 18:53:45 UTC) #5
On 2015/12/01 14:13:32, franziskus wrote:
>
> I actually like when you don't really see the line-continuation backslashes.
But
> the main reason I'm doing that is to be consistent with clang-format, which
does
> it when having a column limit.

Yes, our manual formatting should be consistent with clang-format.

Wan-Teh
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b