Issue 274830043: Tweaks to use new js interop.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 274830043: Tweaks to use new js interop.

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 6 months ago by jacobr

Modified:
8 years, 6 months ago

Reviewers:
jacob314

Base URL:
git@github.com:danschultz/react.dart.git@master

Visibility:
Public.

More Reviews

Description

Tweaks to use new js interop. BUG=

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
M	lib/react.dart	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/react/component.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/react/react_class.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/react/react_element.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

jacob314

8 years, 6 months ago (2015-10-20 21:55:54 UTC) #1

https://codereview.appspot.com/274830043/diff/20001/lib/react/component.dart
File lib/react/component.dart (right):

https://codereview.appspot.com/274830043/diff/20001/lib/react/component.dart#...
lib/react/component.dart:62: var components = <dynamic, Component>{};
probably best to stop using a HashMap here as storing JavaScript objects as keys
in a dart HashMap won't have good performance unless we stick expandos on
JavaScript objects which would have some undesirable side-effects.

https://codereview.appspot.com/274830043/diff/20001/lib/react/react_element.dart
File lib/react/react_element.dart (right):

https://codereview.appspot.com/274830043/diff/20001/lib/react/react_element.d...
lib/react/react_element.dart:25: interopProps = _props(className:
props["className"], onClick: allowInterop(props["onClick"]));
this isn't needed if you ensure that closures passed in to the Map object have
always had allowInterop called. I didn't look closely but it appears this wasn't
the case.
drive by general comment, it would probably be better for performance to use Map
less and define some dart classes with the property, value pairs you need.

Expand All Messages | Collapse All Messages