Issue 274740043: TBR: i#58 MacOS: port test suite, part 3

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 274740043: TBR: i#58 MacOS: port test suite, part 3

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 7 months ago by bruening

Modified:
8 years, 7 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#58 MacOS: port test suite, part 3 Fixes the output from the signal tests to be cross-platform by not printing the signal numbers. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -60 lines)			Patch
M	suite/tests/linux/signal-base.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	suite/tests/linux/signal0000.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal0001.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal0010.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal0011.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal0100.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal0101.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal0110.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal0111.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal1000.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal1001.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal1010.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal1011.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal1100.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal1101.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal1110.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/signal1111.expect	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	suite/tests/linux/sigplain-base.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	suite/tests/linux/sigplain000.expect	View	1 chunk	+1 line, -1 line	0 comments	Download
M	suite/tests/linux/sigplain001.expect	View	1 chunk	+1 line, -1 line	0 comments	Download
M	suite/tests/linux/sigplain010.expect	View	1 chunk	+1 line, -1 line	0 comments	Download
M	suite/tests/linux/sigplain011.expect	View	1 chunk	+1 line, -1 line	0 comments	Download
M	suite/tests/linux/sigplain100.expect	View	1 chunk	+1 line, -1 line	0 comments	Download
M	suite/tests/linux/sigplain101.expect	View	1 chunk	+1 line, -1 line	0 comments	Download
M	suite/tests/linux/sigplain110.expect	View	1 chunk	+1 line, -1 line	0 comments	Download
M	suite/tests/linux/sigplain111.expect	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

8 years, 7 months ago (2015-10-16 20:52:11 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/5248c8d4dac7631a698db94ca343ead...

Final commit log: 
---------------
i#58 MacOS: port test suite, part 3

Fixes the output from the signal tests to be cross-platform by not printing
the signal numbers.

Review-URL: https://codereview.appspot.com/274740043
---------------

Expand All Messages | Collapse All Messages