Issue 274590043: Implement rounded-box whiteout style

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 274590043: Implement rounded-box whiteout style (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 5 months ago by pwm

Modified:
8 years, 4 months ago

Reviewers:
pkx166h, Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Implement rounded-box whiteout style As suggested in issue 4504. Includes edits to regression tests and changes entry.

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -25 lines)			Patch
M	Documentation/changes.tely	View	1 chunk	+16 lines, -7 lines	0 comments	Download
M	input/regression/whiteout.ly	View	2 chunks	+10 lines, -3 lines	0 comments	Download
M	input/regression/whiteout-lower-layers.ly	View	1 chunk	+19 lines, -7 lines	0 comments	Download
M	scm/define-grob-properties.scm	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	scm/define-markup-commands.scm	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	scm/stencil.scm	View	1 chunk	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Trevor Daniels

LGTM When this is pushed we ought to raise an issue to document whiteout properly ...

8 years, 5 months ago (2015-11-26 16:29:59 UTC) #2

pkx166h

8 years, 4 months ago (2015-12-04 15:00:15 UTC) #3

On 2015/11/26 16:29:59, Trevor Daniels wrote:
> LGTM
> 
> When this is pushed we ought to raise an issue to document whiteout properly
in
> the NR.

https://sourceforge.net/p/testlilyissues/issues/4681/

James

Expand All Messages | Collapse All Messages