code review 27430043: net: fix nits found by go tool vet

net: fix nits found by go tool vet

[mikio, 2013-11-17 03:39:10]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-11-17 03:41:02]

Please wait til after 1.2.

On Sun, Nov 17, 2013 at 2:39 PM,  <mikioh.mikioh@gmail.com> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> net: fix nits found by go tool vet
>
> Please review this at https://codereview.appspot.com/27430043/
>
> Affected files (+4, -4 lines):
>   M src/pkg/net/net_test.go
>
>
> Index: src/pkg/net/net_test.go
> ===================================================================
> --- a/src/pkg/net/net_test.go
> +++ b/src/pkg/net/net_test.go
> @@ -231,12 +231,12 @@
>         // Make Listen fail by relistening on the same address.
>         l, err := Listen("tcp", "127.0.0.1:0")
>         if err != nil {
> -               t.Fatal("Listen 127.0.0.1:0: %v", err)
> +               t.Fatalf("Listen 127.0.0.1:0: %v", err)
>         }
>         defer l.Close()
>         l1, err := Listen("tcp", l.Addr().String())
>         if err == nil {
> -               t.Fatal("second Listen %v: %v", l.Addr(), err)
> +               t.Fatalf("second Listen %v: %v", l.Addr(), err)
>         }
>         if l1 != nil {
>                 t.Fatalf("Listen returned non-nil interface %T(%v) with err
> != nil", l1, l1)
> @@ -245,12 +245,12 @@
>         // Make ListenPacket fail by relistening on the same address.
>         lp, err := ListenPacket("udp", "127.0.0.1:0")
>         if err != nil {
> -               t.Fatal("Listen 127.0.0.1:0: %v", err)
> +               t.Fatalf("Listen 127.0.0.1:0: %v", err)
>         }
>         defer lp.Close()
>         lp1, err := ListenPacket("udp", lp.LocalAddr().String())
>         if err == nil {
> -               t.Fatal("second Listen %v: %v", lp.LocalAddr(), err)
> +               t.Fatalf("second Listen %v: %v", lp.LocalAddr(), err)
>         }
>         if lp1 != nil {
>                 t.Fatalf("ListenPacket returned non-nil interface %T(%v)
> with err != nil", lp1, lp1)
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups
> "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[adg, 2013-11-18 01:05:18]

LGTM

But please submit after Go 1.2 is tagged.

[mikio, 2013-12-10 05:30:58]

*** Submitted as https://code.google.com/p/go/source/detail?r=9f67b2b6ee3a ***

net: fix nits found by go tool vet

R=golang-dev, dave, adg
CC=golang-dev
https://codereview.appspot.com/27430043