Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(640)

Issue 274260043: Doc: Usage - Update svg & svg-woff backend text (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years ago by pkx166h
Modified:
2 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: Usage - Update svg & svg-woff backend text Issue 4650 Update explanation so as to inform the user that they will need to make sure that the font/ WOFF font file information for anything other than LP Music glyphs are not included and need to be 'made available' to the SVG viewer separately.

Patch Set 1 #

Total comments: 1

Patch Set 2 : WIth Hosada-san's suggestions and some more tidying up of the section. #

Total comments: 2

Patch Set 3 : Hosada-san`s corrections. #

Total comments: 4

Patch Set 4 : With Trevor's corrections. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -33 lines) Patch
M Documentation/usage/running.itely View 1 2 4 chunks +39 lines, -33 lines 0 comments Download

Messages

Total messages: 12
trueroad
https://codereview.appspot.com/274260043/diff/1/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/274260043/diff/1/Documentation/usage/running.itely#newcode783 Documentation/usage/running.itely:783: handle them. For other font format files use the ...
2 years ago (2015-11-03 13:55:02 UTC) #1
pkx166h
2 years ago (2015-11-03 14:08:34 UTC) #2
pkx166h
On 2015/11/03 13:55:02, trueroad wrote: > https://codereview.appspot.com/274260043/diff/1/Documentation/usage/running.itely > File Documentation/usage/running.itely (right): > > https://codereview.appspot.com/274260043/diff/1/Documentation/usage/running.itely#newcode783 > ...
2 years ago (2015-11-03 14:20:57 UTC) #3
trueroad
On 2015/11/03 14:20:57, pkx166h wrote: > On 2015/11/03 13:55:02, trueroad wrote: > > > https://codereview.appspot.com/274260043/diff/1/Documentation/usage/running.itely ...
2 years ago (2015-11-04 13:10:50 UTC) #4
pkx166h
WIth Hosada-san's suggestions and some more tidying up of the section.
2 years ago (2015-11-05 17:47:26 UTC) #5
trueroad
https://codereview.appspot.com/274260043/diff/20001/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/274260043/diff/20001/Documentation/usage/running.itely#newcode490 Documentation/usage/running.itely:490: additional additional @code{--svg-woff} switch is required. Is `additional' duplicated? ...
2 years ago (2015-11-06 14:09:16 UTC) #6
pkx166h
Hosada-san`s corrections.
2 years ago (2015-11-07 17:13:18 UTC) #7
pkx166h
On 2015/11/06 14:09:16, trueroad wrote: > https://codereview.appspot.com/274260043/diff/20001/Documentation/usage/running.itely > File Documentation/usage/running.itely (right): > > https://codereview.appspot.com/274260043/diff/20001/Documentation/usage/running.itely#newcode490 > ...
2 years ago (2015-11-07 17:17:36 UTC) #8
trueroad
LGTM Thank you.
2 years ago (2015-11-08 03:13:17 UTC) #9
Trevor Daniels
I can't vouch for the technicalities, but LGTM apart from a few typos. https://codereview.appspot.com/274260043/diff/40001/Documentation/usage/running.itely File ...
2 years ago (2015-11-08 23:08:02 UTC) #10
pkx166h
With Trevor's corrections.
2 years ago (2015-11-09 18:03:13 UTC) #11
pkx166h
8 months ago (2017-03-19 19:08:22 UTC) #12
author James Lowe pkx166h@gmail.com
Sun, 1 Nov 2015 11:34:43 +0000 (11:34 +0000)
committer James Lowe pkx166h@gmail.com
Fri, 13 Nov 2015 10:36:35 +0000 (10:36 +0000)
commit 8706e77a804e412e751fdd47385c8ccfdc28e732
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4