On 2015/10/22 12:57:38, robert.erneborg wrote: It looks like everything is new but it isn't. I ...
8 years, 6 months ago
(2015-10-22 13:01:28 UTC)
#2
On 2015/10/22 12:57:38, robert.erneborg wrote:
It looks like everything is new but it isn't. I only changed some names, added
ips for all hosts and added commands for launching all tomcat instances.
https://codereview.appspot.com/274020044/diff/1/topology1.py File topology1.py (right): https://codereview.appspot.com/274020044/diff/1/topology1.py#newcode90 topology1.py:90: #pre_commands(net) Is it required to use this pre_commands(net) line ...
8 years, 6 months ago
(2015-10-22 13:15:11 UTC)
#4
On 2015/10/22 21:00:41, marcus.falgert wrote: > On 2015/10/22 13:15:11, teowey wrote: > > https://codereview.appspot.com/274020044/diff/1/topology1.py > ...
8 years, 6 months ago
(2015-10-23 08:41:15 UTC)
#7
On 2015/10/22 21:00:41, marcus.falgert wrote:
> On 2015/10/22 13:15:11, teowey wrote:
> > https://codereview.appspot.com/274020044/diff/1/topology1.py
> > File topology1.py (right):
> >
> > https://codereview.appspot.com/274020044/diff/1/topology1.py#newcode90
> > topology1.py:90: #pre_commands(net)
> > Is it required to use this pre_commands(net) line when running the get() and
> > cmd() below?
>
> not required, but we should probably put some of the code in fuctions, such as
> the initialization phase (starting servers etc).
I agree. Just remember to commit in the "mininet-topology" branch of
network-emulator repo :)
Issue 274020044: renamed some hosts and switches, added ips for all hosts and added commands for starting tomcat.
Created 8 years, 6 months ago by robert.erneborg
Modified 8 years, 3 months ago
Reviewers: teowey, marcus.falgert, fikri.firman, bruce.yinhe, dkostic, karthik.venkatesan85
Base URL:
Comments: 2