Bug1213948

[CID 1286618][CID 1168239] Using uninitialized value ticketData.type when calling SECITEM_CopyItem_Util

ssl3_ConsumeHandshakeVariable does not initialise the SECItem's type, which leads to undefined behaviour when copying the item later. To solve this I set the item type to siBuffer.

[mt, 2015-10-13 18:01:18]

https://codereview.appspot.com/273790043/diff/1/lib/ssl/ssl3con.c
File lib/ssl/ssl3con.c (right):

https://codereview.appspot.com/273790043/diff/1/lib/ssl/ssl3con.c#newcode4489
lib/ssl/ssl3con.c:4489: i->type = siBuffer;
Since line 4477&8 initialize the other values, I think that you should instead
move this line to there.

[franziskus, 2015-10-13 19:47:23]

On 2015/10/13 18:01:18, mt wrote:
> https://codereview.appspot.com/273790043/diff/1/lib/ssl/ssl3con.c
> File lib/ssl/ssl3con.c (right):
> 
> https://codereview.appspot.com/273790043/diff/1/lib/ssl/ssl3con.c#newcode4489
> lib/ssl/ssl3con.c:4489: i->type = siBuffer;
> Since line 4477&8 initialize the other values, I think that you should instead
> move this line to there.

makes sense, done