Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9103)

Issue 273110043: TBR: i#1801 clang build x86 test failure: add CLANG macro

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by zhaoqin
Modified:
8 years, 6 months ago
Reviewers:
bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1801 clang build x86 test failure: add CLANG macro - add CLANG macron for clang build - use different stack alignment in asm_defines.asm with 32-bit clang build - fixed linux.signalfd on 32-bit clang build ---------------

Patch Set 1 #

Total comments: 2

Patch Set 2 : update commit msg #

Patch Set 3 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M CMakeLists.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M core/arch/asm_defines.asm View 3 chunks +4 lines, -4 lines 0 comments Download
M core/lib/genapi.pl View 1 chunk +1 line, -1 line 0 comments Download
M make/DynamoRIOConfig.cmake.in View 1 chunk +3 lines, -0 lines 0 comments Download
M make/configure.cmake.h View 1 chunk +3 lines, -0 lines 0 comments Download
M suite/tests/CMakeLists.txt View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7
zhaoqin
8 years, 6 months ago (2015-10-28 15:58:10 UTC) #1
zhaoqin
On 2015/10/28 15:58:10, zhaoqin wrote: It is not a TBR, use -t by mistake.
8 years, 6 months ago (2015-10-28 15:58:51 UTC) #2
bruening
On 2015/10/28 15:58:10, zhaoqin wrote: > - add CLANG macron for clang build "macron"? > ...
8 years, 6 months ago (2015-10-28 17:31:04 UTC) #3
zhaoqin
Commit log for latest patchset: --------------- i#1801 clang build x86 test failure: add CLANG macro ...
8 years, 6 months ago (2015-10-28 18:29:43 UTC) #4
bruening
LGTM https://codereview.appspot.com/273110043/diff/1/core/lib/genapi.pl File core/lib/genapi.pl (right): https://codereview.appspot.com/273110043/diff/1/core/lib/genapi.pl#newcode263 core/lib/genapi.pl:263: $def eq "MACOS" || $def eq "X64" || ...
8 years, 6 months ago (2015-10-28 18:41:54 UTC) #5
zhaoqin
https://codereview.appspot.com/273110043/diff/1/core/lib/genapi.pl File core/lib/genapi.pl (right): https://codereview.appspot.com/273110043/diff/1/core/lib/genapi.pl#newcode263 core/lib/genapi.pl:263: $def eq "MACOS" || $def eq "X64" || $def ...
8 years, 6 months ago (2015-10-28 19:06:23 UTC) #6
zhaoqin
8 years, 6 months ago (2015-10-28 19:28:21 UTC) #7
Committed as
https://github.com/DynamoRIO/dynamorio/commit/8cce9cf0e7b1a3493b34503b80499c8...

Final commit log: 
---------------
i#1801 clang build x86 test failure: add CLANG macro

- add CLANG macro for clang build
- use different stack alignment in asm_defines.asm with 32-bit clang build

Review-URL: https://codereview.appspot.com/273110043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b