Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7610)

Issue 272250043: i#1734: Create Dr. Fuzz: adjust MAX_BUFFER_SIZE to 64MB

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by zhaoqin
Modified:
8 years, 6 months ago
Reviewers:
bruening
CC:
drmemory-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1734: Create Dr. Fuzz: adjust MAX_BUFFER_SIZE to 64MB - set MAX_BUFFER_SIZE to 64MB to allow large input ---------------

Patch Set 1 #

Total comments: 3

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M drmemory/fuzzer.c View 1 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 4
zhaoqin
8 years, 6 months ago (2015-10-28 22:10:05 UTC) #1
bruening
LGTM w/ suggestions https://codereview.appspot.com/272250043/diff/1/drmemory/fuzzer.c File drmemory/fuzzer.c (right): https://codereview.appspot.com/272250043/diff/1/drmemory/fuzzer.c#newcode537 drmemory/fuzzer.c:537: #define MAX_BUFFER_SIZE (64*1024*1024) /* 64MB */ ...
8 years, 6 months ago (2015-10-28 22:18:02 UTC) #2
bruening
https://codereview.appspot.com/272250043/diff/1/drmemory/fuzzer.c File drmemory/fuzzer.c (right): https://codereview.appspot.com/272250043/diff/1/drmemory/fuzzer.c#newcode537 drmemory/fuzzer.c:537: #define MAX_BUFFER_SIZE (64*1024*1024) /* 64MB */ On 2015/10/28 22:18:02, ...
8 years, 6 months ago (2015-10-28 22:18:27 UTC) #3
zhaoqin
8 years, 6 months ago (2015-10-28 22:33:53 UTC) #4
Committed as
https://github.com/DynamoRIO/drmemory/commit/f6d1588d542b8cd20f78ab4c5321a5ac...

Final commit log: 
---------------
i#1734: Create Dr. Fuzz: adjust MAX_BUFFER_SIZE to 64MB

- set MAX_BUFFER_SIZE to 64MB to allow large input
- use WARN instead of fatal error on large buffer

Review-URL: https://codereview.appspot.com/272250043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b