Issue 2720044: Refined elList

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2720044: Refined elList (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Bo Schwarzstein

Modified:
13 years, 6 months ago

Reviewers:
Elvic

Base URL:
http://elvishrender.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Refined as comments again. #

Total comments: 2

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -48 lines)			Patch
eiCORE/UnitTest/eiListUnitTest.h	View	1	4 chunks	+8 lines, -6 lines	1 comment	Download
eiCORE/eiList.h	View	1	2 chunks	+26 lines, -26 lines	0 comments	Download
eiCORE/eiList.c	View	1	9 chunks	+15 lines, -16 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Elvic

Generally it's a good changelist. http://codereview.appspot.com/2720044/diff/1/eiCORE/UnitTest/eiListUnitTest.h File eiCORE/UnitTest/eiListUnitTest.h (right): http://codereview.appspot.com/2720044/diff/1/eiCORE/UnitTest/eiListUnitTest.h#newcode23 eiCORE/UnitTest/eiListUnitTest.h:23: eiNode node; You are ...

13 years, 6 months ago (2010-11-01 03:32:19 UTC) #1

Elvic

13 years, 6 months ago (2010-11-01 05:47:51 UTC) #3

Here're my comments regarding your changelist:

http://codereview.appspot.com/2720044/diff/7001/eiCORE/UnitTest/eiListUnitTest.h
File eiCORE/UnitTest/eiListUnitTest.h (right):

http://codereview.appspot.com/2720044/diff/7001/eiCORE/UnitTest/eiListUnitTes...
eiCORE/UnitTest/eiListUnitTest.h:23: ei_node node;
using ei_list_node may be better? such that ei_slist can have ei_slist_node, and
ei_btree can have ei_btree_node.

http://codereview.appspot.com/2720044/diff/7001/eiCORE/eiList.c
File eiCORE/eiList.c (right):

http://codereview.appspot.com/2720044/diff/7001/eiCORE/eiList.c#newcode167
eiCORE/eiList.c:167: }
list->head.prev = NULL; is still needed, sorry.

Expand All Messages | Collapse All Messages