Issue 271790044: TBR: i#1789: drsyms versioned symbol support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 271790044: TBR: i#1789: drsyms versioned symbol support

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 6 months ago by bruening

Modified:
8 years, 6 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1789: drsyms versioned symbol support Adds support such that a lookup for "foo" matches any versioned instance of foo such as "foo@@GLIBC_3.2". Fixes an ELF lookup error on a NULL section. Adds additional diagnostics in debug build. Fixes #1789 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -11 lines)			Patch
	M	ext/drsyms/drsyms_elf.c	View		8 chunks	+29 lines, -10 lines	0 comments	Download
	M	ext/drsyms/drsyms_unix_common.c	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

8 years, 6 months ago (2015-10-09 05:26:05 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/cdde7b93fe9fcf02f0d5e228e26617b...

Final commit log: 
---------------
i#1789: drsyms versioned symbol support

Adds support such that a lookup for "foo" matches any versioned instance of
foo such as "foo@@GLIBC_3.2".

Fixes an ELF lookup error on a NULL section.

Adds additional diagnostics in debug build.

Fixes #1789

Review-URL: https://codereview.appspot.com/271790044
---------------

Expand All Messages | Collapse All Messages