Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(120)

Issue 271240043: Bug 1215295 - Support RSA-PSS for digital signing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by ttaubert
Modified:
6 years, 3 months ago
Reviewers:
ekr, mt, rrelyea, ekr-rietveld
Visibility:
Public.

Description

Bug 1215295 - Support RSA-PSS for digital signing

Patch Set 1 #

Patch Set 2 : Bug 1215295 - Support RSA-PSS for digital signing #

Total comments: 15

Patch Set 3 : Bug 1215295 - Support RSA-PSS for digital signing #

Total comments: 8

Patch Set 4 : Bug 1215295 - Support RSA-PSS for digital signing #

Total comments: 1

Patch Set 5 : Bug 1215295 - Support RSA-PSS for digital signing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+433 lines, -2 lines) Patch
A external_tests/common/scoped_ptrs.h View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download
M external_tests/manifest.mn View 1 chunk +1 line, -0 lines 0 comments Download
A external_tests/pk11_gtest/Makefile View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
A external_tests/pk11_gtest/manifest.mn View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A external_tests/pk11_gtest/pk11_gtest.cc View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A external_tests/pk11_gtest/pk11_rsapss_unittest.cc View 1 2 3 1 chunk +247 lines, -0 lines 0 comments Download
M lib/nss/nss.def View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M lib/pk11wrap/pk11obj.c View 1 2 4 chunks +33 lines, -2 lines 0 comments Download
M lib/pk11wrap/pk11pub.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7
ekr-rietveld
https://codereview.appspot.com/271240043/diff/20001/external_tests/pk11_gtest/manifest.mn File external_tests/pk11_gtest/manifest.mn (left): https://codereview.appspot.com/271240043/diff/20001/external_tests/pk11_gtest/manifest.mn#oldcode9 external_tests/pk11_gtest/manifest.mn:9: # These sources have access to libssl internals Rietveld ...
6 years, 9 months ago (2015-11-06 21:31:59 UTC) #1
ttaubert
https://codereview.appspot.com/271240043/diff/20001/external_tests/pk11_gtest/manifest.mn File external_tests/pk11_gtest/manifest.mn (left): https://codereview.appspot.com/271240043/diff/20001/external_tests/pk11_gtest/manifest.mn#oldcode9 external_tests/pk11_gtest/manifest.mn:9: # These sources have access to libssl internals On ...
6 years, 9 months ago (2015-11-09 17:27:18 UTC) #2
mt
LGTM https://codereview.appspot.com/271240043/diff/40001/external_tests/pk11_gtest/Makefile File external_tests/pk11_gtest/Makefile (right): https://codereview.appspot.com/271240043/diff/40001/external_tests/pk11_gtest/Makefile#newcode54 external_tests/pk11_gtest/Makefile:54: OS_CFLAGS += -MTd -EHsc -nologo Check the latest ...
6 years, 9 months ago (2015-11-09 18:04:14 UTC) #3
ekr-rietveld
LGTM with changes below https://codereview.appspot.com/271240043/diff/40001/external_tests/pk11_gtest/gtest_utils.h File external_tests/pk11_gtest/gtest_utils.h (right): https://codereview.appspot.com/271240043/diff/40001/external_tests/pk11_gtest/gtest_utils.h#newcode34 external_tests/pk11_gtest/gtest_utils.h:34: } // namespace nss_test This ...
6 years, 9 months ago (2015-11-09 18:37:07 UTC) #4
ttaubert
All feedback addressed, thanks!
6 years, 9 months ago (2015-11-09 19:06:00 UTC) #5
mt
LGTM with one nit https://codereview.appspot.com/271240043/diff/60001/external_tests/common/scoped_ptrs.h File external_tests/common/scoped_ptrs.h (right): https://codereview.appspot.com/271240043/diff/60001/external_tests/common/scoped_ptrs.h#newcode8 external_tests/common/scoped_ptrs.h:8: #define gtest_utils_h__ Fix name
6 years, 9 months ago (2015-11-09 19:17:36 UTC) #6
ttaubert
6 years, 9 months ago (2015-11-09 19:43:02 UTC) #7
On 2015/11/09 19:17:36, mt wrote:
> LGTM with one nit
> 
>
https://codereview.appspot.com/271240043/diff/60001/external_tests/common/sco...
> File external_tests/common/scoped_ptrs.h (right):
> 
>
https://codereview.appspot.com/271240043/diff/60001/external_tests/common/sco...
> external_tests/common/scoped_ptrs.h:8: #define gtest_utils_h__
> Fix name

Oh, thanks for spotting this.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b