Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(262)

Issue 271180045: NSSClang-Arrays

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by franziskus
Modified:
6 years, 7 months ago
Reviewers:
ekr-rietveld
Visibility:
Public.

Description

NSSClang-Arrays

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -174 lines) Patch
M cmd/certutil/keystuff.c View 1 chunk +1 line, -1 line 0 comments Download
M cmd/fipstest/fipstest.c View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cmd/libpkix/pkixutil/pkixutil.c View 1 1 chunk +1 line, -1 line 0 comments Download
M cmd/makepqg/makepqg.c View 1 chunk +1 line, -1 line 0 comments Download
M cmd/pk1sign/pk1sign.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/certdb/certdb.c View 1 chunk +1 line, -1 line 0 comments Download
M lib/certdb/crl.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/certdb/genname.c View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/certdb/secname.c View 1 1 chunk +3 lines, -3 lines 0 comments Download
M lib/certdb/xbsconst.c View 1 chunk +1 line, -1 line 0 comments Download
M lib/certdb/xconst.c View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/certhigh/ocspsig.c View 1 2 chunks +4 lines, -4 lines 0 comments Download
M lib/crmf/crmftmpl.c View 1 chunk +1 line, -1 line 0 comments Download
M lib/cryptohi/dsautil.c View 1 chunk +1 line, -1 line 0 comments Download
M lib/cryptohi/seckey.c View 1 2 chunks +13 lines, -13 lines 0 comments Download
M lib/cryptohi/secsign.c View 1 2 chunks +14 lines, -14 lines 0 comments Download
M lib/cryptohi/secvfy.c View 1 chunk +1 line, -1 line 0 comments Download
M lib/libpkix/pkix_pl_nss/module/pkix_pl_httpcertstore.c View 1 1 chunk +3 lines, -3 lines 0 comments Download
M lib/pkcs7/secmime.c View 1 1 chunk +3 lines, -3 lines 0 comments Download
M lib/smime/smimeutil.c View 1 2 chunks +4 lines, -4 lines 0 comments Download
M lib/softoken/fipstest.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/softoken/legacydb/lowcert.c View 1 1 chunk +9 lines, -9 lines 0 comments Download
M lib/softoken/legacydb/lowkey.c View 3 chunks +5 lines, -5 lines 0 comments Download
M lib/softoken/lowkey.c View 3 chunks +5 lines, -5 lines 0 comments Download
M lib/softoken/pkcs11c.c View 1 1 chunk +6 lines, -6 lines 0 comments Download
M lib/ssl/ssl3con.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/ssl/sslcon.c View 1 1 chunk +8 lines, -8 lines 0 comments Download
M lib/ssl/sslinfo.c View 1 1 chunk +70 lines, -70 lines 0 comments Download
M lib/util/templates.c View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6
ekr-rietveld
https://codereview.appspot.com/271180045/diff/1/lib/ssl/sslcon.c File lib/ssl/sslcon.c (right): https://codereview.appspot.com/271180045/diff/1/lib/ssl/sslcon.c#newcode64 lib/ssl/sslcon.c:64: { 0, 0, 0, 0 }, This seems odd. ...
6 years, 7 months ago (2015-11-09 12:46:40 UTC) #1
franziskus
https://codereview.appspot.com/271180045/diff/1/lib/ssl/sslcon.c File lib/ssl/sslcon.c (right): https://codereview.appspot.com/271180045/diff/1/lib/ssl/sslcon.c#newcode64 lib/ssl/sslcon.c:64: { 0, 0, 0, 0 }, On 2015/11/09 12:46:40, ...
6 years, 7 months ago (2015-11-09 14:06:36 UTC) #2
ekr-rietveld
You seem to have some sort of git rebase issue here. https://codereview.appspot.com/271180045/diff/20001/lib/certhigh/ocspsig.c File lib/certhigh/ocspsig.c (right): ...
6 years, 7 months ago (2015-11-10 16:35:11 UTC) #3
franziskus
On 2015/11/10 16:35:11, ekr-webrtc wrote: > You seem to have some sort of git rebase ...
6 years, 7 months ago (2015-11-10 16:43:56 UTC) #4
ekr-rietveld
Ugh. This is the same patch. Can you file a new issue with this patch ...
6 years, 7 months ago (2015-11-10 17:23:00 UTC) #5
franziskus
6 years, 7 months ago (2015-11-10 17:29:40 UTC) #6
On 2015/11/10 17:23:00, ekr-webrtc wrote:
> Ugh. This is the same patch. Can you file a new issue with this patch so I can
> look at it cleanly?

hm, strange. put it up again https://codereview.appspot.com/272460043/ looks
clean to me...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b