Remove unused variable kPathSeparatorString

Remove unused variable kPathSeparatorString.

Consumers of kPathSeparatorString were removed in gtest r370. With warnings
cranked up, the following is produced:

gtest/src/gtest-filepath.cc:87:12: error: unused variable 'kPathSeparatorString' [-Werror,-Wunused-const-variable]
const char kPathSeparatorString[] = "/";
           ^

This variable is unused and unnecessary.

[wan, 2013-11-16 00:49:40]

Corey,

Would you be able to take this one?  Thanks.


On Fri, Nov 15, 2013 at 4:43 PM, <mark@chromium.org> wrote:

> Reviewers: wan,
>
> Description:
> Remove unused variable kPathSeparatorString.
>
> Consumers of kPathSeparatorString were removed in gtest r370. With
> warnings
> cranked up, the following is produced:
>
> gtest/src/gtest-filepath.cc:87:12: error: unused variable
> 'kPathSeparatorString' [-Werror,-Wunused-const-variable]
> const char kPathSeparatorString[] = "/";
>            ^
>
> This variable is unused and unnecessary.
>
> Please review this at https://codereview.appspot.com/27100043/
>
> Affected files (+0, -2 lines):
>   M     src/gtest-filepath.cc
>
>
> Index: src/gtest-filepath.cc
> ===================================================================
> --- src/gtest-filepath.cc       (revision 664)
> +++ src/gtest-filepath.cc       (working copy)
> @@ -70,7 +70,6 @@
>  // of them.
>  const char kPathSeparator = '\\';
>  const char kAlternatePathSeparator = '/';
> -const char kPathSeparatorString[] = "\\";
>  const char kAlternatePathSeparatorString[] = "/";
>  # if GTEST_OS_WINDOWS_MOBILE
>  // Windows CE doesn't have a current directory. You should not use
> @@ -84,7 +83,6 @@
>  # endif  // GTEST_OS_WINDOWS_MOBILE
>  #else
>  const char kPathSeparator = '/';
> -const char kPathSeparatorString[] = "/";
>  const char kCurrentDirectoryString[] = "./";
>  #endif  // GTEST_OS_WINDOWS
>
>
>
>


-- 
Zhanyong

[yangge1987_gmail.com, 2016-08-09 06:44:25]

is this patch ever merged?

The google test framework hasn't been updated since 2013. Is this project 
abandoned?

On Friday, November 15, 2013 at 4:49:19 PM UTC-8, Zhanyong Wan wrote:
>
> Corey,
>
> Would you be able to take this one?  Thanks.
>
>
> On Fri, Nov 15, 2013 at 4:43 PM, <ma...@chromium.org <javascript:>> wrote:
>
>> Reviewers: wan,
>>
>> Description:
>> Remove unused variable kPathSeparatorString.
>>
>> Consumers of kPathSeparatorString were removed in gtest r370. With
>> warnings
>> cranked up, the following is produced:
>>
>> gtest/src/gtest-filepath.cc:87:12: error: unused variable
>> 'kPathSeparatorString' [-Werror,-Wunused-const-variable]
>> const char kPathSeparatorString[] = "/";
>>            ^
>>
>> This variable is unused and unnecessary.
>>
>> Please review this at https://codereview.appspot.com/27100043/
>>
>> Affected files (+0, -2 lines):
>>   M     src/gtest-filepath.cc
>>
>>
>> Index: src/gtest-filepath.cc
>> ===================================================================
>> --- src/gtest-filepath.cc       (revision 664)
>> +++ src/gtest-filepath.cc       (working copy)
>> @@ -70,7 +70,6 @@
>>  // of them.
>>  const char kPathSeparator = '\\';
>>  const char kAlternatePathSeparator = '/';
>> -const char kPathSeparatorString[] = "\\";
>>  const char kAlternatePathSeparatorString[] = "/";
>>  # if GTEST_OS_WINDOWS_MOBILE
>>  // Windows CE doesn't have a current directory. You should not use
>> @@ -84,7 +83,6 @@
>>  # endif  // GTEST_OS_WINDOWS_MOBILE
>>  #else
>>  const char kPathSeparator = '/';
>> -const char kPathSeparatorString[] = "/";
>>  const char kCurrentDirectoryString[] = "./";
>>  #endif  // GTEST_OS_WINDOWS
>>
>>
>>
>>
>
>
> -- 
> Zhanyong 
>