Issue 271000043: Manually set the local ip property

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 271000043: Manually set the local ip property

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 6 months ago by robert.erneborg

Modified:
8 years, 3 months ago

Reviewers:
marcus.falgert, fikri.firman, dkostic, teowey, karthik.venkatesan85, bruce.yinhe

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	crypt.properties	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	src/main/java/se/kth/crypt/server/config/ServerConfig.java	View		2 chunks	+8 lines, -1 line	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

robert.erneborg

Sometimes the server will pick the wrong interface when trying to retrieve the local ip ...

8 years, 6 months ago (2015-10-22 12:24:21 UTC) #1

marcus.falgert

https://codereview.appspot.com/271000043/diff/1/src/main/java/se/kth/crypt/server/config/ServerConfig.java File src/main/java/se/kth/crypt/server/config/ServerConfig.java (right): https://codereview.appspot.com/271000043/diff/1/src/main/java/se/kth/crypt/server/config/ServerConfig.java#newcode285 src/main/java/se/kth/crypt/server/config/ServerConfig.java:285: else serverNode.setIpLocal(ipLocal); looks good!

8 years, 6 months ago (2015-10-22 21:00:50 UTC) #2

teowey

On 2015/10/22 21:00:50, marcus.falgert wrote: > https://codereview.appspot.com/271000043/diff/1/src/main/java/se/kth/crypt/server/config/ServerConfig.java > File src/main/java/se/kth/crypt/server/config/ServerConfig.java (right): > > https://codereview.appspot.com/271000043/diff/1/src/main/java/se/kth/crypt/server/config/ServerConfig.java#newcode285 > ...

8 years, 6 months ago (2015-10-27 08:24:09 UTC) #3

Expand All Messages | Collapse All Messages